feat(vehicle_cmd_gate): improve debug marker activation #5426
+42
−1
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Oct 30, 2023 in 41s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method vehicle_cmd_gate.cpp: VehicleCmdGate::VehicleCmdGate
- Complex Conditional vehicle_cmd_gate.cpp: VehicleCmdGate::publishMarkers
Annotations
Check warning on line 807 in control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
VehicleCmdGate::publishMarkers has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 169 in control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
VehicleCmdGate::VehicleCmdGate increases from 152 to 159 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading