-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tier4_planning_launch): use xml style launch #5448
refactor(tier4_planning_launch): use xml style launch #5448
Conversation
360bd74
to
00a5621
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5448 +/- ##
==========================================
- Coverage 14.72% 14.72% -0.01%
==========================================
Files 1665 1665
Lines 116244 116114 -130
Branches 36038 35964 -74
==========================================
- Hits 17117 17095 -22
+ Misses 79734 79657 -77
+ Partials 19393 19362 -31
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6192471
to
f11c104
Compare
Fix wrong topic remapping. (turn signal, hazard signal.) |
f11c104
to
0863f39
Compare
<include file="$(find-pkg-share tier4_planning_launch)/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.xml"> | ||
<arg name="container_type" value="component_container_mt"/> | ||
<!-- This condition should be true if run_out module is enabled and its detection method is Points --> | ||
<arg name="launch_compare_map_pipeline" value="false"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary for users to manually change launch_compare_map_pipeline
?
In behavior_planning_launch.py
, this parameter was automatically set to true when both the run_out module was launched and the method for the run_out
module was set to Points
.
Lines 228 to 229 in a2b114d
launch_run_out = run_out_module in behavior_velocity_planner_params["launch_modules"] | |
launch_run_out_with_points_method = launch_run_out and run_out_method == "Points" |
If it's challenging to replicate this automatic behavior in launch.xml, it might be acceptable to require users to manually set it to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomohitoAndo Thanks!
If it's challenging to replicate this automatic behavior in launch.xml, it might be acceptable to require users to manually set it to true.
I'll try it. But it might be difficult...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomohitoAndo Sorry, it is a little bit difficult to improve it quickly...
Anyway, I would like to refactor launch files so that we can launch only modules we want to use more easily. So, I'll take this issue into consideration and improve as much as I can in that work.
Then, I would like you to change this arg manually for a while. Is it ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Thank you for trying!
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
0863f39
to
5981eeb
Compare
…tion#5448) * refactor(tier4_planning_launch): use xml style launch Signed-off-by: satoshi-ota <[email protected]> * refactor(tier4_planning_launch): remove python style launch Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…tion#5448) * refactor(tier4_planning_launch): use xml style launch Signed-off-by: satoshi-ota <[email protected]> * refactor(tier4_planning_launch): remove python style launch Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Description
🤖 Generated by Copilot at 360bd74
Refactor and update the launch files for the planning module to use ROS 2 features and improve performance and modularity. Delete unused and duplicated launch files and nodes. Add new parameters and remappings for the behavior planning nodes.
Please review following PR at first:
autowarefoundation/autoware_launch#671
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.