Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_planning_launch): use xml style launch #5448

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 31, 2023

Description

🤖 Generated by Copilot at 360bd74

Refactor and update the launch files for the planning module to use ROS 2 features and improve performance and modularity. Delete unused and duplicated launch files and nodes. Add new parameters and remappings for the behavior planning nodes.

Please review following PR at first:
autowarefoundation/autoware_launch#671

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Oct 31, 2023
@satoshi-ota satoshi-ota force-pushed the refactor/behavior-xml-launch branch from 360bd74 to 00a5621 Compare October 31, 2023 08:06
@satoshi-ota satoshi-ota marked this pull request as ready for review October 31, 2023 08:13
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75f7357) 14.72% compared to head (f11c104) 14.72%.
Report is 1 commits behind head on main.

❗ Current head f11c104 differs from pull request most recent head 5981eeb. Consider uploading reports for the commit 5981eeb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5448      +/-   ##
==========================================
- Coverage   14.72%   14.72%   -0.01%     
==========================================
  Files        1665     1665              
  Lines      116244   116114     -130     
  Branches    36038    35964      -74     
==========================================
- Hits        17117    17095      -22     
+ Misses      79734    79657      -77     
+ Partials    19393    19362      -31     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 14.72% <ø> (-0.01%) ⬇️ Carriedforward from a194589

*This pull request uses carry forward flags. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota force-pushed the refactor/behavior-xml-launch branch 2 times, most recently from 6192471 to f11c104 Compare October 31, 2023 14:13
@satoshi-ota
Copy link
Contributor Author

Fix wrong topic remapping. (turn signal, hazard signal.)

@satoshi-ota satoshi-ota force-pushed the refactor/behavior-xml-launch branch from f11c104 to 0863f39 Compare November 1, 2023 04:42
<include file="$(find-pkg-share tier4_planning_launch)/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.xml">
<arg name="container_type" value="component_container_mt"/>
<!-- This condition should be true if run_out module is enabled and its detection method is Points -->
<arg name="launch_compare_map_pipeline" value="false"/>
Copy link
Contributor

@TomohitoAndo TomohitoAndo Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary for users to manually change launch_compare_map_pipeline?
In behavior_planning_launch.py, this parameter was automatically set to true when both the run_out module was launched and the method for the run_out module was set to Points.

launch_run_out = run_out_module in behavior_velocity_planner_params["launch_modules"]
launch_run_out_with_points_method = launch_run_out and run_out_method == "Points"

If it's challenging to replicate this automatic behavior in launch.xml, it might be acceptable to require users to manually set it to true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed run_out with Points method works when launch_compare_map_pipeline is true.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomohitoAndo Thanks!

If it's challenging to replicate this automatic behavior in launch.xml, it might be acceptable to require users to manually set it to true.

I'll try it. But it might be difficult...

Copy link
Contributor Author

@satoshi-ota satoshi-ota Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomohitoAndo Sorry, it is a little bit difficult to improve it quickly...
Anyway, I would like to refactor launch files so that we can launch only modules we want to use more easily. So, I'll take this issue into consideration and improve as much as I can in that work.

Then, I would like you to change this arg manually for a while. Is it ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Thank you for trying!

@satoshi-ota satoshi-ota force-pushed the refactor/behavior-xml-launch branch from 0863f39 to 5981eeb Compare November 2, 2023 00:47
@satoshi-ota satoshi-ota merged commit 5fc1bd8 into autowarefoundation:main Nov 2, 2023
19 checks passed
@satoshi-ota satoshi-ota deleted the refactor/behavior-xml-launch branch November 2, 2023 07:23
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 9, 2023
…tion#5448)

* refactor(tier4_planning_launch): use xml style launch

Signed-off-by: satoshi-ota <[email protected]>

* refactor(tier4_planning_launch): remove python style launch

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2023
…tion#5448)

* refactor(tier4_planning_launch): use xml style launch

Signed-off-by: satoshi-ota <[email protected]>

* refactor(tier4_planning_launch): remove python style launch

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants