-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change): regulate at the traffic light #5457
Merged
zulfaqar-azmi-t4
merged 2 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:fix-lane-change-at-traffic-light
Nov 17, 2023
Merged
fix(lane_change): regulate at the traffic light #5457
zulfaqar-azmi-t4
merged 2 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:fix-lane-change-at-traffic-light
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
purewater0901
as code owners
November 1, 2023 10:41
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 1, 2023
4 tasks
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 2, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5457 +/- ##
==========================================
- Coverage 14.79% 14.79% -0.01%
==========================================
Files 1684 1684
Lines 116772 116785 +13
Branches 36271 36277 +6
==========================================
Hits 17277 17277
- Misses 79989 80000 +11
- Partials 19506 19508 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
fix-lane-change-at-traffic-light
branch
from
November 7, 2023 06:49
76939cf
to
64a80d8
Compare
rej55
approved these changes
Nov 16, 2023
zulfaqar-azmi-t4
merged commit Nov 17, 2023
9071619
into
autowarefoundation:main
19 of 23 checks passed
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
) * fix(lane_change): regulate at the traffic light Signed-off-by: Zulfaqar Azmi <[email protected]> * fix conflict Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regulate lane change at the traffic light.
In this PR, by setting
regulate_on_traffic_light
totrue
, lane change module accepts path only whenBefore PR
After PR
cap-.2023-11-01-18-38-36.mp4
Logic
Related links
Parameter is needed autowarefoundation/autoware_launch#673
Tests performed
Evaluator's result https://evaluation.tier4.jp/evaluation/reports/9838be5d-03a2-5bca-94f1-f2170b0ea15a?project_id=prd_jt
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.