Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(planning modules): remove maintainer... #5458

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Nov 1, 2023

Description

🤖 Generated by Copilot at 5cdfcb4

Removed Yutaka Shimizu's email from the maintainer fields of several package.xml files in the common, control, perception, and planning directories. Added or updated the emails of the current maintainers of some packages, especially those related to the turn signal decider and stop line modules. These changes update the package information to reflect the current status of the project.


remove maintainer from planning modules because the person doesn't maintain the modules for now.
we will add him in near future, of course.

However, for the turn signal decider and stop line module, someone should be assigned as the maintainer.

TODO

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…nd turn signal decider

Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 1, 2023
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a2b114d) 14.71% compared to head (5cdfcb4) 14.42%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5458      +/-   ##
==========================================
- Coverage   14.71%   14.42%   -0.30%     
==========================================
  Files        1665     1713      +48     
  Lines      116223   118671    +2448     
  Branches    36027    36039      +12     
==========================================
+ Hits        17107    17118      +11     
- Misses      79733    82161    +2428     
- Partials    19383    19392       +9     
Flag Coverage Δ *Carryforward flag
differential 16.50% <47.82%> (?)
total 14.71% <ø> (+<0.01%) ⬆️ Carriedforward from a2b114d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...nal_controller/src/pid_longitudinal_controller.cpp 39.41% <66.66%> (+0.23%) ⬆️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 25.31% <45.00%> (+1.09%) ⬆️

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit f662ac7 into autowarefoundation:main Nov 7, 2023
34 of 35 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the chore/miss_shimizu_san branch November 7, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.