Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(planning_validator): not publish diag before data is ready #5461

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(planning_validator): not publish diag before data is ready #5461

merged 1 commit into from
Nov 2, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Nov 1, 2023 •
edited
Loading

Description

Setup diagnostic updater after all data is ready. Otherwise, the /diagnostic is published with ERROR state before it is ready.

Before

  • diag is published with ERROR state before the required data is received

After

  • diag is NOT published before the required data is received

Related links

None

Tests performed

Run psim

Notes for reviewers

None

Interface changes

None

Effects on system behavior

See Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe requested a review from kosuke55 as a code owner November 1, 2023 12:43
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 1, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 1, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) November 1, 2023 12:45
tkimura4
tkimura4 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit 012de21 into autowarefoundation:main Nov 2, 2023
31 of 32 checks passed
@TakaHoribe TakaHoribe deleted the planning-validator-diag-pub branch November 2, 2023 02:54
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkimura4 tkimura4 tkimura4 approved these changes

@kosuke55 kosuke55 kosuke55 approved these changes

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TakaHoribe @kosuke55 @tkimura4