refactor(tier4_planning_launch): use xml style launch #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:launch
satoshi-ota
force-pushed
the
refactor/motion-xml-launch
branch
2 times, most recently
from
8a7cd76 to
e6de612
Compare
4 tasks
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
satoshi-ota
force-pushed
the
refactor/motion-xml-launch
branch
from
e6de612 to
1585cba
Compare
github-actions
bot
added
type:documentation
satoshi-ota
force-pushed
the
refactor/motion-xml-launch
branch
from
1585cba to
9c3c316
Compare
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
refactor/motion-xml-launch
branch
from
9c3c316 to
9d5f763
Compare
github-actions
bot
removed
type:documentation
satoshi-ota
added
the
run:build-and-test-differential
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5470 +/- ##
=======================================
Coverage 14.86% 14.86%
=======================================
Files 1666 1666
Lines 116258 116258
Branches 36266 36266
=======================================
Hits 17277 17277
Misses 79476 79476
Partials 19505 19505
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Nov 7, 2023
…tion#5470) * refactor(tier4_planning_launch): use xml style launch Signed-off-by: satoshi-ota <[email protected]> * refactor(tier4_planning_launch): remove python style launch Signed-off-by: satoshi-ota <[email protected]> * fix(tier4_plannning_launch): fix namespace Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 9, 2023
…tion#5470) * refactor(tier4_planning_launch): use xml style launch Signed-off-by: satoshi-ota <[email protected]> * refactor(tier4_planning_launch): remove python style launch Signed-off-by: satoshi-ota <[email protected]> * fix(tier4_plannning_launch): fix namespace Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 30, 2023
…tion#5470) * refactor(tier4_planning_launch): use xml style launch Signed-off-by: satoshi-ota <[email protected]> * refactor(tier4_planning_launch): remove python style launch Signed-off-by: satoshi-ota <[email protected]> * fix(tier4_plannning_launch): fix namespace Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 2add154
This pull request updates the motion planning launch files for lane driving scenario to use the new ROS 2 features of composable node container and load_composable_node. It also allows the user to choose different types of nodes for path planning and obstacle stop functionalities. It also fixes a typo in the
scenario_planning.launch.xmlfile.Please review following PR at first.
autowarefoundation/autoware_launch#675
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.