Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maintainer Yoshi Ri to packages #6552

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 6, 2024

Description

Add maintainer to to some packages.
See TIER IV INTERNAL LINK.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <[email protected]>
@YoshiRi YoshiRi self-assigned this Mar 6, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 6, 2024
Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 6, 2024
@YoshiRi YoshiRi enabled auto-merge (squash) March 6, 2024 08:42
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 6, 2024

@manato Could you approve this owner adding PR?

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.79%. Comparing base (5206580) to head (e91dbee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6552   +/-   ##
=======================================
  Coverage   14.78%   14.79%           
=======================================
  Files        1917     1917           
  Lines      132018   131950   -68     
  Branches    39226    39198   -28     
=======================================
- Hits        19523    19520    -3     
+ Misses      90706    90655   -51     
+ Partials    21789    21775   -14     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from ab6b7e3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara
Copy link
Contributor

@manato
Can you review this PR when you have time?

Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay of my review. LGTM!

@YoshiRi YoshiRi merged commit fc2b2c6 into main Mar 12, 2024
26 checks passed
@YoshiRi YoshiRi deleted the chore/update_maintainer_yoshiri branch March 12, 2024 11:13
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
chore: add maintainer

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants