revert: feat(global_parameter_loader): add gtest to global parameter loader #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loader (…" This reverts commit dfec62a.
github-actions
bot
added
the
component:common
mitsudome-r
approved these changes
Apr 24, 2024
mitsudome-r
added
the
run:build-and-test-differential
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 25, 2024
…loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a.
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 25, 2024
…loader (backport autowarefoundation#6872) (#1274) revert: feat(global_parameter_loader): add gtest to global parameter loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a.
mergify bot
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 25, 2024
…loader (backport autowarefoundation#6872) (#1274) revert: feat(global_parameter_loader): add gtest to global parameter loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a. (cherry picked from commit e5196bc)
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 25, 2024
…loader (backport autowarefoundation#6872) (backport #1274) (#1275) revert: feat(global_parameter_loader): add gtest to global parameter loader (backport autowarefoundation#6872) (#1274) revert: feat(global_parameter_loader): add gtest to global parameter loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a. (cherry picked from commit e5196bc) Co-authored-by: Hiroki OTA <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…loader (autowarefoundation#6872) Revert "feat(global_parameter_loader): add gtest to global parameter loader (…" This reverts commit dfec62a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
This PR reverts #5021
Now this package depends another package, sample_vehicle_launch for gtest.
The gtest should be unit test, in other words, it should not has any dependency.
And, It is not good that a package depends on sample packages.
So, I revert this change and find another solutions.
Solutions include refactoring -> #6874
Related Links
TIER IV INTERNAL LINK:https://star4.slack.com/archives/C4P0NSMB5/p1713916234357319