Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_objects_of_interest_marker_interface): fix bugprone-branch-clone #9671

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-branch-clone error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_objects_of_interest_marker_interface/src/objects_of_interest_marker_interface.cpp:85:5: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
    case ColorName::GRAY:
    ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_objects_of_interest_marker_interface/src/objects_of_interest_marker_interface.cpp:88:38: note: last of these clones ends here
      return coloring::getGray(alpha);
                                     ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <[email protected]>
@kobayu858 kobayu858 requested a review from veqcc December 17, 2024 04:48
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 17, 2024
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kobayu858 I want to keep this skipped with a ignore lint comment, since the meaning of GRAY gets unclear

Signed-off-by: kobayu858 <[email protected]>
@kobayu858
Copy link
Contributor Author

@soblin
Thanks for the confirmation. I have made the change to suppress it in the comments.

@kobayu858 kobayu858 requested a review from soblin December 17, 2024 05:37
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.83%. Comparing base (c17b000) to head (dc9b19d).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
...rface/src/objects_of_interest_marker_interface.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9671   +/-   ##
=======================================
  Coverage   29.82%   29.83%           
=======================================
  Files        1443     1447    +4     
  Lines      108599   108626   +27     
  Branches    42667    42665    -2     
=======================================
+ Hits        32395    32405   +10     
- Misses      73024    73038   +14     
- Partials     3180     3183    +3     
Flag Coverage Δ *Carryforward flag
differential 30.45% <0.00%> (?)
total 29.84% <ø> (+0.01%) ⬆️ Carriedforward from f78ab3d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@soblin
Please confirm the PR. Thank you very much.

Signed-off-by: kobayu858 <[email protected]>
@xmfcx xmfcx merged commit c11d613 into autowarefoundation:main Dec 25, 2024
36 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants