Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planning_evaluator): update lateral_trajectory_displacement to absolute value #9696

Conversation

Kazunori-Nakajima
Copy link
Contributor

Description

Changed lateral_trajectory_displacement to absolute value.
This is to make it easier to determine when testing(TIER IV Internal use case).

Related links

Parent Issue:

  • Link

How was this PR tested?

Before

Screenshot from 2024-12-20 10-37-45

After

Screenshot from 2024-12-20 10-42-25

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2024
@kosuke55 kosuke55 force-pushed the fix/planning_evaluator_lataral_trajectory_displacement branch from aab3107 to e13c8b8 Compare December 23, 2024 02:05
@kosuke55 kosuke55 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 23, 2024
@kosuke55 kosuke55 enabled auto-merge (squash) December 23, 2024 02:05
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.53%. Comparing base (4dc7201) to head (58de7a0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9696      +/-   ##
==========================================
+ Coverage   29.41%   29.53%   +0.12%     
==========================================
  Files        1446     1446              
  Lines      108365   107899     -466     
  Branches    42232    42050     -182     
==========================================
- Hits        31872    31869       -3     
+ Misses      73408    72945     -463     
  Partials     3085     3085              
Flag Coverage Δ *Carryforward flag
differential 8.36% <100.00%> (?)
total 29.54% <ø> (+0.12%) ⬆️ Carriedforward from 485ccc6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the fix/planning_evaluator_lataral_trajectory_displacement branch from e13c8b8 to 58de7a0 Compare January 10, 2025 08:21
@kosuke55 kosuke55 merged commit 76aa83f into autowarefoundation:main Jan 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants