refactor(autoware_universe_utils): add missing 's' in the class of diagnostics_interface #9777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agnostics_interface Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
component:localization
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kminoda
added
the
run:build-and-test-differential
kminoda
requested review from
anhnv3991,
isamu-takagi,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4,
YamatoAndo,
soblin,
TakaHoribe and
takayuki5168
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9777 +/- ##
==========================================
+ Coverage 29.68% 29.70% +0.02%
==========================================
Files 1450 1451 +1
Lines 108833 108834 +1
Branches 42740 42740
==========================================
+ Hits 32305 32328 +23
+ Misses 73357 73330 -27
- Partials 3171 3176 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YamatoAndo
approved these changes
Dec 25, 2024
soblin
approved these changes
Dec 27, 2024
kminoda
added a commit
to kminoda/autoware.universe
that referenced
this pull request
Dec 27, 2024
…agnostics_interface (autowarefoundation#9777) Signed-off-by: kminoda <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 6, 2025
…agnostics_interface (autowarefoundation#9777) Signed-off-by: kminoda <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 6, 2025
…agnostics_interface (autowarefoundation#9777) Signed-off-by: kminoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I mistakenly named the object "DiagnosticInterface", but would be better to name it "DiagnosticsInterface". Currently the name of the class is inconsistent with the file name as well.
Related links
None
How was this PR tested?
Tested with logging_simulator that the localization starts without any failure. Also confirmed that the diagnostics messages are published from localization nodes.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.