Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_processing_time_checker): fix bugprone-exception-escape #9780

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-exception-escape error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/system/autoware_processing_time_checker/src/processing_time_checker.cpp:100:24: error: an exception may be thrown in function '~ProcessingTimeChecker' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
ProcessingTimeChecker::~ProcessingTimeChecker()
                       ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <[email protected]>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
@kobayu858 kobayu858 requested a review from veqcc December 25, 2024 05:53
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 29.67%. Comparing base (3d53032) to head (63619b1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ssing_time_checker/src/processing_time_checker.cpp 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9780      +/-   ##
==========================================
+ Coverage   29.66%   29.67%   +0.01%     
==========================================
  Files        1450     1450              
  Lines      108833   108849      +16     
  Branches    42740    42745       +5     
==========================================
+ Hits        32285    32305      +20     
+ Misses      73375    73373       -2     
+ Partials     3173     3171       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.68% <ø> (+0.02%) ⬆️ Carriedforward from 20cd7cc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kobayu858 <[email protected]>
@kobayu858 kobayu858 merged commit d0c39d3 into autowarefoundation:main Dec 25, 2024
36 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…utowarefoundation#9780)

* fix: bugprone-error

Signed-off-by: kobayu858 <[email protected]>

* fix: cpplint

Signed-off-by: kobayu858 <[email protected]>

---------

Signed-off-by: kobayu858 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants