feat(autoware_control_evaluator): add new boundary_distance metrics #9984
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jan 23, 2025 in 47s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.21 (9.84 -> 9.63)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method control_evaluator_node.cpp: ControlEvaluatorNode::onTimer
- Bumpy Road Ahead control_evaluator_node.cpp: ControlEvaluatorNode::AddBoundaryDistanceMetricMsg
Annotations
Check warning on line 322 in evaluator/autoware_control_evaluator/src/control_evaluator_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
ControlEvaluatorNode::onTimer has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 207 in evaluator/autoware_control_evaluator/src/control_evaluator_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
ControlEvaluatorNode::AddBoundaryDistanceMetricMsg has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading