Remove IdentifierSource edit option (fixes #1564)

[shashank2043]

Removed the edit option for the IdentifierSource

Summary by CodeRabbit

• Bug Fixes
  • Editing for the Identifier Source in the Admin UI is now disabled; creation remains subject to existing privilege checks.
  • This change affects only the Identifier Source section; all other resources and workflows remain unchanged in the Admin UI.
  • Edit controls for this resource will no longer appear.
  • Applies to all users, regardless of previous edit privileges.

[coderabbitai]

Walkthrough

The Admin UI’s Identifier Source Resource configuration was updated in src/adminApp/OrgManager.jsx to set its edit prop to false, disabling editing for that resource. Creation behavior remains controlled by the existing privilege check. No other files or resources were modified.

Changes

Cohort / File(s)	Summary
Admin UI Resource Config src/adminApp/OrgManager.jsx	Set the Resource named identifierSource edit prop from hasPrivilege(userInfo, EditIdentifierSource) && IdentifierSourceEdit to false, disabling edit. Creation logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through forms with gentle care,
A toggle flips—no edits there.
Create may bloom where rights allow,
But pencils sleep in fields for now.
Thump-thump! The UI’s calm and terse—
One carrot click, a safer verse.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The title succinctly and accurately describes the primary change—removing the IdentifierSource edit option—which matches the changes in the PR that disable editing for the IdentifierSource; including "(fixes #1564)" is a common and acceptable reference to the tracked issue.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/adminApp/OrgManager.jsx (1)

178-179: Editing disabled for Identifier Source — verified no lingering edit UI

• IdentifierSourceList / IdentifierSourceDetail contain no EditButton or edit navigation (src/adminApp/IdentifierSource.jsx).
• OrgManager registers Resource name="identifierSource" with edit={false} (src/adminApp/OrgManager.jsx, ~lines 169–177).
• Creation remains conditional: hasPrivilege(userInfo, EditIdentifierSource) && IdentifierSourceCreate — flip to false only if product requires disabling creation.
• Optional: suppress any custom edit UI by passing a prop to the detail component:

show={WithProps({ hasEditPrivilege: false }, IdentifierSourceDetail)}

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f76624 and f43f7ca.

📒 Files selected for processing (1)

• src/adminApp/OrgManager.jsx (1 hunks)