Xfstest fixes with upstream as a target #2778
Conversation
|
inih-devel header dependency failure (1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: STARTED |
|
local.config file not found error (1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: ERROR: stat: path should be string, bytes, os.PathLike or integer, not NoneType (23.60 s) |
|
@PraveenPenguin @abdhaleegit should I resubmit this after the Travis check issue is resolved? |
|
Yes @sacsant it is fixed , can you please resend the request |
sacsant
force-pushed
the
xfstest
branch
2 times, most recently
from
b497387
to
99f5795
Compare
|
Test results after the fix: w/64k page size + upstream w/4k page size + upstream |
Using upstream as a target to compile xfsprogs code, following failure is encountered: Command 'make' failed.\nstdout: b"libtoolize -c -i -f\nlibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.\nlibtoolize: copying file './config.guess'\nlibtoolize: copying file './config.sub'\nlibtoolize: copying file './install-sh'\nlibtoolize: ... (5.46 s) Add inih-devel package as dependency so that this package will be installed. Signed-off-by: Sachin Sant <[email protected]>
With upstream as a target, xfstest test fails to copy local.config (1/1) fs/xfstests.py:Xfstests.test;run-disk_type-fs_type-fs_xfs_4k-run_type-upstream-8eea: ERROR: stat: path should be string, bytes, os.PathLike or integer, not NoneType (23.60 s) This happens since teststmpdir directory is changed during compilation of upstream code (various progs). Move the stub before the upstream as a target check stanza to avoid this failure. Signed-off-by: Sachin Sant <[email protected]>
|
@disgoel can you please review this PR |
For SUSE libinih-devel is begin installed and is taken care. |
In case a certain package install operation fails, the test fails with a completely different message ERROR: 'Xfstests' object has no attribute 'scratch_mnt' (15.37 s) The package install function is called before various variable initialization. In case of install fail, test errors out due to usage of uniniitalized variables in teardown. Move the package install function call post variable initialization Signed-off-by: Sachin Sant <[email protected]>
On SUSE some of the packages used by xfstest script are available with a different name. Update the __setUp_packages function accordingly to use the correct package names. Signed-off-by: Sachin Sant <[email protected]>
|
I have added couple of fixes to address issues found when package install fails commit 144455c addresses following issue when a package installation fails Before fix: After fix: Fourth commit adjusts package dependency to suit naming convention of various distro releases. |
PraveenPenguin
merged commit 86b6fbf
into
avocado-framework-tests:master
|
@PraveenPenguin there is an issue with the last commit 3fc8e18. A comma is missing after 'userspace-rcu-devel'. Do you want me to send another fix or push this branch again to integrate updated code? |
With upstream as a target following failures are observed
This 2 patch series fixes these problem.
Signed-off-by: Sachin Sant [email protected]