virsh: align same usage for emulatorpin #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually the options value should be started with --. The old codes added '--' in this utility function which is not suitable. We expect the client provides like '--config' to invoke this function as other functions do. Signed-off-by: Dan Zheng <[email protected]>
dzhengfy
force-pushed
the
fix_emulatorpin_option
branch
from
af7e6a9
to
8bf212f
Compare
|
I will submit other tp-libvirt PRs to align with this changes |
dzhengfy
added a commit
to dzhengfy/tp-libvirt
that referenced
this pull request
Jul 25, 2023
These changes are to align with below patch. avocado-framework/avocado-vt#3722 Signed-off-by: Dan Zheng <[email protected]>
chloerh
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the options value should be started with --. The old codes added '--' in this utility function which is not suitable. We expect the client provides like '--config' to invoke this function as other functions do.
Signed-off-by: Dan Zheng [email protected]