utils_disk/libvirt_disk: add way to handle disk by path #3729
+36
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
get_parts_list_by_path
branch
from
7890122
to
3aeb20c
Compare
smitterl
changed the title
smitterl
force-pushed
the
get_parts_list_by_path
branch
from
3aeb20c
to
4345a92
Compare
|
Used in autotest/tp-libvirt#5060 |
chloerh
reviewed
Aug 15, 2023
virttest/utils_disk.py
Outdated
| if err: | ||
| raise exceptions.TestError("Failed to list partitions in /dev/disk/by-path") | ||
| r = out.split() | ||
| logging.debug("Partitions by path: %s", r) |
There was a problem hiding this comment.
Suggested change
| logging.debug("Partitions by path: %s", r) | |
| LOG.debug("Partitions by path: %s", r) |
There was a problem hiding this comment.
@chloerh Thank you! Updated.
Partitions in /proc/partitions are not persistent which can lead to problems when a test checks if a disk was cold plugged. Use persistent naming from /dev/disk/by-path which allows us to easily identify those disks and partitions with the attached disk by their libvirt <address/>. Add and update other functions to be compatible with this way of dealing with partitions. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
get_parts_list_by_path
branch
from
4345a92
to
d303afb
Compare
chloerh
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partitions in /proc/partitions are not persistent which
can lead to problems when a test checks if a disk was cold
plugged.
Use persistent naming from /dev/disk/by-path which allows
.us to easily identify those disks and partitions with
the attached disk by their libvirt
Add and update other functions to be compatible with this way
of dealing with partitions.