-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I1101 E721 are newly enforced python code style #3732
I1101 E721 are newly enforced python code style #3732
Conversation
inspekt checkall --disable-lint W,R,C,E0203,E0601,E1002,E1101,E1102,E1103,E1120,F0401,I0011,E1003,W605 --disable-style W605,W606,E501,E265,W601,E402,E722,E741 --exclude avocado-libs,scripts/github --no-license-check Your code has been rated at 10.00/10 make: *** [Makefile:49: check] Error 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to fix some of these but a lot more issues popped up. So, I agree with you @chunfuwen to disable these. Thank you!
@@ -46,7 +46,7 @@ requirements: pip | |||
- $(PYTHON) -m pip install -r requirements.txt | |||
|
|||
check: | |||
inspekt checkall --disable-lint W,R,C,E0203,E0601,E1002,E1101,E1102,E1103,E1120,F0401,I0011,E1003,W605 --disable-style W605,W606,E501,E265,W601,E402,E722,E741 --exclude avocado-libs,scripts/github --no-license-check | |||
inspekt checkall --disable-lint W,R,C,E0203,E0601,E1002,E1101,E1102,E1103,E1120,F0401,I0011,E1003,W605,I1101 --disable-style W605,W606,E501,E265,W601,E402,E722,E741,E721 --exclude avocado-libs,scripts/github --no-license-check | |||
pylint --errors-only --disable=all --enable=spelling --spelling-dict=en_US --spelling-private-dict-file=spell.ignore * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For E721 `do not compare types, for exact checks use is / is not, for instance checks use isinstance(), I think we can easily fix instead of disable. We already did the similar fix in tp-libvirt autotest/tp-libvirt#5066. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzhengfy , fixing E721 issues, and leave I1101 unchecked now
c4121d1
to
34c4180
Compare
This cause multiple checking failure in currect codes, so fix E721 issue and disable I1101 Signed-off-by: chunfuwen <[email protected]>
34c4180
to
426a02d
Compare
@chunfuwen As sebas's #3734 was ready for merging ealier than this one, so his pr was merged. Thanks for your understanding. Could you help close this one? |
I1101 E721 are newly enforced python code style
This cause multiple checking failure in currect codes, so disable them