Fix static checker #3734
Merged
Fix static checker #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
fix_static_checker
branch
2 times, most recently
from
f1a94e1
to
288d327
Compare
Yingshun
reviewed
Aug 4, 2023
scripts/regression.py
Outdated
| @@ -235,7 +235,7 @@ def getTtestPvalue(self, fs_dict1, fs_dict2, paired=None, ratio=None): | |||
|
|
|||
| for line in range(len(s1)): | |||
| tmp = [] | |||
| if type(s1[line]) != list: | |||
| if not isinstance(s1[line]), list): | |||
There was a problem hiding this comment.
Suggested change
| if not isinstance(s1[line]), list): | |
| if not isinstance(s1[line], list): |
smitterl
force-pushed
the
fix_static_checker
branch
from
288d327
to
c8fd017
Compare
Fix several E721 errors. The latest pycodestyle (prev. pep8 package) demands this. I1101 is enforced with recent updates. This causes a lot of problems. It complains about missing information about members of imports. Let's ignore this as we want to check our own code mainly. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
fix_static_checker
branch
from
c8fd017
to
be700e1
Compare
Yingshun
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution for #3732
Ignore I1101 but fix E721
Fixes for E721 applied as indicated by https://github.com/PyCQA/pycodestyle/blob/1c2147c703e3b934675b270391fab03cb30d73a2/CHANGES.txt#L12