Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated flask-cors to address Issue #21 #22

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Updated flask-cors to address Issue #21 #22

merged 3 commits into from
Jul 8, 2020

Conversation

trevorrobertsjr
Copy link

Issue #, if available:
#21

Description of changes:
Updated flask-cors from 3.0.0 to 3.0.8 to address CORS issues

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Trevor Roberts Jr added 3 commits April 13, 2020 17:21
flask-cors 3.0.0 does not properly pass the required headers to prevent CORS errors
Flask 0.12.2 does not pin the Werkzeug dependency version and odd "AttributeError...is_xhr" errors populate the logs. Flask 0.12.5 pins the Werkzeug version dependency to avoid these errors.
flask-cors 3.0.0 does not properly pass the required headers to prevent CORS errors
Flask 0.12.2 does not pin the Werkzeug dependency version and odd "AttributeError...is_xhr" errors populate the logs. Flask 0.12.5 pins the Werkzeug version dependency to avoid these errors.
Copy link
Collaborator

@MitchyBAwesome MitchyBAwesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. I am merging. Thanks @trevorrobertsjr

@MitchyBAwesome MitchyBAwesome merged commit f0e047d into aws-samples:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants