Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed GlueColumn base class #424

Merged

Conversation

Jeremynadal33
Copy link
Contributor

resolves #423

Description

I changed the parent class of GlueColumn from Column (from dbt base) to SparkColumn

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moomindani moomindani self-assigned this Aug 27, 2024
@moomindani moomindani added the enable-functional-tests This label enable functional tests label Aug 27, 2024
@moomindani moomindani merged commit ad1ee05 into aws-samples:main Aug 27, 2024
17 checks passed
@moomindani
Copy link
Collaborator

Thank you for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor enable-functional-tests This label enable functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use merge_update_columns or merge_exclude_columns
2 participants