Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed GlueColumn base class #424

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- Fix session provisioning timeout and delay handling
- Add on_schema_change possibility
- Fix table materialization for Delta models
- Change GlueColumn parent from base Column to SparkColumn

## v1.8.1
- Fix typo in README.md
Expand Down
4 changes: 2 additions & 2 deletions dbt/adapters/glue/column.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
from dataclasses import dataclass
from typing import ClassVar, Dict

from dbt.adapters.base.column import Column
from dbt.adapters.spark.column import SparkColumn


@dataclass
class GlueColumn(Column):
class GlueColumn(SparkColumn):
# Overwriting dafult string types to support glue
# TODO: Convert to supported glue types as needed
# Please ref: https://github.com/dbt-athena/dbt-athena/blob/main/dbt/adapters/athena/column.py
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/test_column.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import unittest

from dbt.adapters.glue.column import GlueColumn


class TestGlueColumn(unittest.TestCase):
def test_column_quote(self):
test_column = GlueColumn("col_name", "INT")
self.assertEqual(test_column.quoted, "`col_name`")
Loading