Update integ tests for new EFA Metrics #569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
reviewed
Sep 11, 2025
| //}, | ||
| "ClusterName-Namespace-PodName": { | ||
| // podEfaRxBytes, podEfaTxBytes, podEfaRxDropped, podEfaRdmaReadBytes, podEfaRdmaWriteBytes, podEfaRdmaWriteRecvBytes, | ||
| podEfaLimit, podEfaRequest, podEfaUsageTotal, podEfaReservedCapacity, |
There was a problem hiding this comment.
The pod metrics should also be available for {"Service", "Namespace", "ClusterName"} as per the agent PR.. can we check if we are missing that here?
| nodeEfaRdmaWriteBytes = "node_efa_rdma_write_bytes" | ||
| nodeEfaRdmaWriteRecvBytes = "node_efa_rdma_write_recv_bytes" | ||
| nodeEfaLimit = "node_efa_limit" | ||
| nodeEfaRequest = "node_efa_request" |
There was a problem hiding this comment.
I dont see a node_efa_request in https://github.com/aws/amazon-cloudwatch-agent/pull/1815/files .. so how is this test even passing?
There was a problem hiding this comment.
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue