Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable selecting the '.NET 6 on AL2023' platform when deploying to Elastic Beanstalk on Linux #807

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Dec 5, 2023

Issue #, if available: #806 (I had tested this quickly when talking to @shruti0085 internally about this issue)

Description of changes:

This widens the string we use to filter Beanstalk Platform options when deploying to Linux, to include the new ".NET 6 on AL2023" platform that was released in October.

image

Considerations:

Dec  5 22:10:04 ip-172-31-83-112 web[2147]: You must install or update .NET to run this application.
Dec  5 22:10:04 ip-172-31-83-112 web[2147]: App: /var/app/current/ASPNet5.dll
Dec  5 22:10:04 ip-172-31-83-112 web[2147]: Architecture: x64
Dec  5 22:10:04 ip-172-31-83-112 web[2147]: Framework: 'Microsoft.AspNetCore.App', version '5.0.0' (x64)

However this is true even for the recent AL2 platform versions as well. Unsure if we want to unblock AL2023 initially with this, then better handle the compatibility between the application being deploying and the specific selected platform later? Or try to tackle both issues together

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8785c3) 61.44% compared to head (86248a3) 61.44%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #807   +/-   ##
=======================================
  Coverage   61.44%   61.44%           
=======================================
  Files         277      277           
  Lines       10659    10659           
  Branches     1484     1484           
=======================================
  Hits         6549     6549           
  Misses       3568     3568           
  Partials      542      542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashovlin ashovlin changed the title fix: Enable selecting the '.NET 6 on AL2023' platform when deploying to Elastic Beanstalk on Linux [WIP] fix: Enable selecting the '.NET 6 on AL2023' platform when deploying to Elastic Beanstalk on Linux Dec 6, 2023
@ashovlin ashovlin changed the title [WIP] fix: Enable selecting the '.NET 6 on AL2023' platform when deploying to Elastic Beanstalk on Linux fix: Enable selecting the '.NET 6 on AL2023' platform when deploying to Elastic Beanstalk on Linux Dec 8, 2023
@ashovlin ashovlin requested a review from normj December 8, 2023 18:19
@ashovlin
Copy link
Member Author

ashovlin commented Dec 8, 2023

Deploying an application with an older target (in this case .NET 5) to the new AL2023 platform results in:

Dec  5 22:10:04 ip-172-31-83-112 web[2147]: You must install or update .NET to run this application.
Dec  5 22:10:04 ip-172-31-83-112 web[2147]: App: /var/app/current/ASPNet5.dll
Dec  5 22:10:04 ip-172-31-83-112 web[2147]: Architecture: x64
Dec  5 22:10:04 ip-172-31-83-112 web[2147]: Framework: 'Microsoft.AspNetCore.App', version '5.0.0' (x64)

However this is true even for the recent AL2 platform versions as well. Unsure if we want to unblock AL2023 initially with this, then better handle the compatibility between the application being deploying and the specific selected platform later? Or try to tackle both issues together

We discussed this in today's GitHub triage meeting with @normj , we're comfortable NOT closing this gap at this point. We expect users to be moving off of .NET Core 3.1 and .NET 5 anyway.

@ashovlin ashovlin requested a review from normj December 20, 2023 04:36
@ashovlin ashovlin force-pushed the shovlia/beanstalk-al2023 branch from 7ad351b to 86248a3 Compare December 21, 2023 17:59
@ashovlin ashovlin merged commit 6447501 into dev Jan 4, 2024
11 checks passed
@ashovlin ashovlin deleted the shovlia/beanstalk-al2023 branch January 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants