Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform query logic to support deprecated #882

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

gcbeattyAWS
Copy link
Contributor

@gcbeattyAWS gcbeattyAWS commented Nov 12, 2024

Issue #, if available: N/A

Description of changes:

  1. Update platform query logic to support deprecated beanstalk platforms. Why? .net 6 is was just marked as deprecated by beanstalk a couple days ago and now customers cannot deploy .net 6 to beanstalk with deploy tool. This change updates the logic so that .net 6 will work by allowing deprecated versions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gcbeattyAWS gcbeattyAWS changed the base branch from main to dev November 12, 2024 15:22
@gcbeattyAWS gcbeattyAWS marked this pull request as ready for review November 12, 2024 15:26
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.35%. Comparing base (d0464a1) to head (3320de3).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #882       +/-   ##
===========================================
+ Coverage   33.67%   62.35%   +28.68%     
===========================================
  Files         279      279               
  Lines       10908    10908               
  Branches     1515     1515               
===========================================
+ Hits         3673     6802     +3129     
+ Misses       6936     3568     -3368     
- Partials      299      538      +239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcbeattyAWS gcbeattyAWS requested a review from normj November 12, 2024 17:44
@gcbeattyAWS gcbeattyAWS merged commit cc33364 into dev Nov 12, 2024
11 checks passed
@gcbeattyAWS gcbeattyAWS deleted the gcbeatty/net6 branch November 12, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants