Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform query logic to support deprecated #882

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Update platform query logic to support deprecated #882

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
589d9b9
Try updating platform query
gcbeattyAWS Nov 11, 2024
baed511
Autover
gcbeattyAWS Nov 12, 2024
c758327
update bootstrap
gcbeattyAWS Nov 12, 2024
3320de3
update changelog
gcbeattyAWS Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .autover/changes/721a3463-3ad9-413d-b2b6-11efb7575fac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"Projects": [
{
"Name": "AWS.Deploy.CLI",
"Type": "Patch",
"ChangelogMessages": [
"Update beanstalk platform resolution logic"
gcbeattyAWS marked this conversation as resolved.
Show resolved Hide resolved
]
}
]
}
8 changes: 6 additions & 2 deletions src/AWS.Deploy.Orchestration/CDK/CDKBootstrapTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,11 @@ Resources:
- Id: CleanupOldVersions
Status: Enabled
NoncurrentVersionExpiration:
NoncurrentDays: 365
NoncurrentDays: 30
- Id: AbortIncompleteMultipartUploads
Status: Enabled
AbortIncompleteMultipartUpload:
DaysAfterInitiation: 1
UpdateReplacePolicy: Delete
DeletionPolicy: Delete
StagingBucketPolicy:
Expand Down Expand Up @@ -611,7 +615,7 @@ Resources:
Type: String
Name:
Fn::Sub: /cdk-bootstrap/${Qualifier}/version
Value: "23"
Value: "25"
Outputs:
BucketName:
Description: The name of the S3 bucket owned by the CDK toolkit stack
Expand Down
2 changes: 1 addition & 1 deletion src/AWS.Deploy.Orchestration/Data/AWSResourceQueryer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ public async Task<List<PlatformSummary>> GetElasticBeanstalkPlatformArns(string?
if (string.IsNullOrEmpty(version.PlatformCategory) || string.IsNullOrEmpty(version.PlatformBranchLifecycleState))
continue;

if (!version.PlatformBranchLifecycleState.Equals("Supported"))
if (!(version.PlatformBranchLifecycleState.Equals("Supported") || version.PlatformBranchLifecycleState.Equals("Deprecated")))
continue;

platformVersions.Add(version);
Expand Down
Loading