chore(build): replace -Wc++-compat' with -x c++'
#578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
added a commit
that referenced
this pull request
Sep 5, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
5911dad to
2bd3bac
Compare
aws-nslick
requested review from
bwbarrett,
rauteric and
a team
as code owners
aws-nslick
added a commit
that referenced
this pull request
Sep 5, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
2bd3bac to
cbe140f
Compare
aws-nslick
added a commit
that referenced
this pull request
Sep 5, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
cbe140f to
fd60d1b
Compare
aws-nslick
added a commit
that referenced
this pull request
Sep 5, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
2 times, most recently
from
9576dfb to
4158878
Compare
aws-nslick
added a commit
that referenced
this pull request
Sep 6, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
that referenced
this pull request
Sep 8, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
4158878 to
8fa891c
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
8fa891c to
1f776af
Compare
aws-nslick
added a commit
that referenced
this pull request
Sep 9, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
that referenced
this pull request
Sep 9, 2024
Add a distcheck build that sets CFLAGS such that it treats all files as C++, preventing pull requests from breaking C++ compatibility going forward. stack-info: PR: #578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
force-pushed
the
aws-nslick/stack/25
branch
from
1f776af to
aad2f1b
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 28, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 28, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 29, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 2, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 3, 2024
As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source files in the tree are both valid C++ source code AND valid C code. Convert wcpp-compat distcheck builds to actually build with C++, to prevent future pull requests from breaking C++ compatibility going forward. stack-info: PR: aws#578, branch: aws-nslick/stack/25 Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with-x c++' #578chore(build): replace
-Wc++-compat' with-x c++'As of this commit, a build with CFLAGS="-x c++" succeeds; ie: all source
files in the tree are both valid C++ source code AND valid C code.
Convert wcpp-compat distcheck builds to actually build with C++, to
prevent future pull requests from breaking C++ compatibility going
forward.
Signed-off-by: Nicholas Sielicki [email protected]