feat(build): disable semantic interposition #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
added a commit
that referenced
this pull request
Sep 26, 2024
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]> stack-info: PR: #624, branch: aws-nslick/stack/37
aws-nslick
force-pushed
the
aws-nslick/stack/37
branch
from
3e46268 to
f7490c5
Compare
This was referenced Sep 26, 2024
|
Frustratingly, this PR needed to be reopened so that it could be rebased atop #594. The old PR was #601 @bwbarrett previously commented:
I've removed it. Also two comments around using
I have removed them. In general, I don't agree with autotools that these flags should be avoided. There are certain flags that cannot be expressed when LIBS/LDFLAGS/CFLAGS are kept entirely separate. eg: Sorry for the trouble, thank you. |
bwbarrett
previously approved these changes
Sep 26, 2024
|
Yeah, the split of LIBS and LDFLAGS is not as big of a deal to me. But passing linker flags to every compilation step is weird, which is why I called those out. The only time I have strong feelings on LIBS vs. LDFLAGS is that in-tree libtool archives need to be in LIBS for all the dependency analysis to work correctly. Other than that, do what makes sense between LIBS and LDFLAGS. |
aws-nslick
added a commit
that referenced
this pull request
Sep 26, 2024
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]> stack-info: PR: #624, branch: aws-nslick/stack/37
aws-nslick
force-pushed
the
aws-nslick/stack/37
branch
from
f7490c5 to
f6b3bd9
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 26, 2024
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]> stack-info: PR: aws#624, branch: aws-nslick/stack/37
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 26, 2024
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]> stack-info: PR: aws#624, branch: aws-nslick/stack/37
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]> stack-info: PR: #624, branch: aws-nslick/stack/37
aws-nslick
force-pushed
the
aws-nslick/stack/37
branch
from
f6b3bd9 to
a225f9f
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]> stack-info: PR: aws#624, branch: aws-nslick/stack/37
|
Checks are marked as failed, but actually passed: https://pr.nccl.plugin.jenkins.samwise.annapurna.aws.dev/job/NCCL%20Plugin%20PR%20CI/view/change-requests/job/PR-624/3/ |
bwbarrett
approved these changes
Sep 27, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Tell the compiler to treat symbols marked explicitly as NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the compiler the freedom to assume that no external LD_PRELOAD'd library can inject itself as an implementation of any given function in the library, which means the compiler has the freedom to optimize across function. Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
feat(build): disable semantic interposition
Tell the compiler to treat symbols marked explicitly as
NCCL_OFI_EXPORT_SYMBOL as preemptible, but not others. This gives the
compiler the freedom to assume that no external LD_PRELOAD'd library can
inject itself as an implementation of any given function in the library,
which means the compiler has the freedom to optimize across function.
Signed-off-by: Nicholas Sielicki [email protected]