fix(tree): use empty brace initializers for zero-initialization #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/34
branch
from
fd644c1 to
80a8c2c
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
f7f49ac to
af08352
Compare
This was referenced Sep 12, 2024
Merged
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
1da3bb4 to
0e1f044
Compare
|
This is apparently only valid in C since C23 (https://en.cppreference.com/w/c/language/struct_initialization), which makes me wary. |
|
It is only valid in recent C, but GCC has been happy with it for some time. If it doesn't cause warnings on AL2 or U20 with our default debug compiler flags, I'd ship it. It'll make the C++ conversion easier. |
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 13, 2024
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: aws#594, branch: aws-nslick/stack/35
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
0e1f044 to
5502846
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
5502846 to
6b9309a
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
6b9309a to
7fd55d0
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: aws#594, branch: aws-nslick/stack/35
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: aws#594, branch: aws-nslick/stack/35
bwbarrett
previously approved these changes
Sep 24, 2024
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 25, 2024
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: aws#594, branch: aws-nslick/stack/35
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 25, 2024
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: aws#594, branch: aws-nslick/stack/35
Signed-off-by: Nicholas Sielicki <[email protected]>
prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid
-Wmissing-field-initializers warnings.
stack-info: PR: #594, branch: aws-nslick/stack/35
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
force-pushed
the
aws-nslick/stack/35
branch
from
7fd55d0 to
33adec5
Compare
rauteric
approved these changes
Sep 26, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
) prefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid -Wmissing-field-initializers warnings. Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(tree): use empty brace initializers for zero-initialization
prefer
struct foo bar = {}' tostruct foo bar = { 0 }' to avoid-Wmissing-field-initializers warnings.
Signed-off-by: Nicholas Sielicki [email protected]