Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): parse as c++ source #568

Closed
wants to merge 1 commit into from
Closed

feat(test): parse as c++ source #568

wants to merge 1 commit into from

Conversation

aws-nslick
Copy link
Contributor

@aws-nslick aws-nslick commented Sep 4, 2024 •
edited
Loading

Stacked PRs:

feat(test): parse as c++ source

All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.
Signed-off-by: Nicholas Sielicki [email protected]

@aws-nslick aws-nslick requested review from rauteric and a team as code owners September 4, 2024 16:44
aws-nslick added a commit that referenced this pull request Sep 4, 2024
@aws-nslick
tests: move to c++
e7c5e0c 
stack-info: PR: #568, branch: aws-nslick/stack/15
This was referenced Sep 4, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/14 to master September 4, 2024 19:07
aws-nslick added a commit that referenced this pull request Sep 4, 2024
@aws-nslick
tests: move to c++
c811e90 
stack-info: PR: #568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/14 September 4, 2024 19:08
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/14 to master September 4, 2024 19:16
aws-nslick added a commit that referenced this pull request Sep 4, 2024
@aws-nslick
tests: move to c++
ae28f30 
stack-info: PR: #568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/14 September 4, 2024 19:17
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/14 to master September 4, 2024 20:25
aws-nslick added a commit that referenced this pull request Sep 4, 2024
@aws-nslick
feat(test): port to c++
0e17dd3 
stack-info: PR: #568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(test): parse as c++ source
9cf4c5f 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(test): parse as c++ source
81ec627 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(test): parse as c++ source
97d1326 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(test): parse as c++ source
5111336 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(test): parse as c++ source
0b6f93f 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 2, 2024
@aws-nslick
feat(test): parse as c++ source
256a0ee 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 3, 2024
@aws-nslick
feat(test): parse as c++ source
5ee550b 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
b362fad 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
47f42d8 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
c719f7b 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
5319c67 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
5eb9de8 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
193fdcd 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
31ceb0c 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
c67d844 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
4af952b 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
d890cb2 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
c5ea412 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
dd40000 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
39ba61f 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
05c3930 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
93d3e7d 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
12650e5 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
4d96321 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
30d315a 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
be386e3 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
96fca99 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
336cdba 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
22f55f8 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 4, 2024
@aws-nslick
feat(test): parse as c++ source
ba90f10 
All included headers are fully safe to be parsed as C++, so these unit
tests can now use C++. Rename them to `.cc' files and use a few c++
keywords to enforce that the compiler is actually treating them as such.
Actual C++ cleanups to follow later, hopefully alongside a unit test
framework like gtest or catch2.

stack-info: PR: aws#568, branch: aws-nslick/stack/15
Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauteric rauteric rauteric left review comments

@bwbarrett bwbarrett bwbarrett approved these changes

@rajachan rajachan Awaiting requested review from rajachan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-nslick @rauteric @bwbarrett