Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): use decltype instead of typeof for cxx #565

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(tree): use decltype instead of typeof for cxx #565

merged 2 commits into from
Sep 27, 2024

Conversation

aws-nslick
Copy link
Contributor

@aws-nslick aws-nslick commented Sep 4, 2024 •
edited
Loading

Stacked PRs:

fix(tree): use decltype instead of typeof for cxx

Signed-off-by: Nicholas Sielicki [email protected]

@aws-nslick aws-nslick requested a review from a team as a code owner September 4, 2024 16:44
This was referenced Sep 4, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/11 to master September 4, 2024 19:07
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/11 September 4, 2024 19:08
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/11 to master September 4, 2024 19:16
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/11 September 4, 2024 19:17
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/11 to master September 4, 2024 20:25
@aws-nslick aws-nslick changed the title cuda: cxx: use decltype instead of typeof for cxx fix(cuda): use decltype instead of typeof for cxx Sep 4, 2024
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/11 September 4, 2024 20:25
@aws-nslick aws-nslick mentioned this pull request Sep 4, 2024
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/11 to master September 14, 2024 22:36
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/10 September 14, 2024 22:37
@aws-nslick
fix(tree): use decltype instead of typeof for cxx
93206c3 
stack-info: PR: #565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/10 to master September 17, 2024 20:24
@aws-nslick aws-nslick changed the title fix(cuda): use decltype instead of typeof for cxx fix(tree): use decltype instead of typeof for cxx Sep 17, 2024
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/10 September 17, 2024 20:25
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
fix(tree): use decltype instead of typeof for cxx
083028b 
stack-info: PR: aws#565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
fix(tree): use decltype instead of typeof for cxx
2efe0e2 
stack-info: PR: aws#565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
fix(tree): use decltype instead of typeof for cxx
b471b06 
stack-info: PR: aws#565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
fix(tree): use decltype instead of typeof for cxx
7d22261 
stack-info: PR: aws#565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
bwbarrett
bwbarrett approved these changes Sep 26, 2024
View reviewed changes
include/nccl_ofi_math.h Show resolved Hide resolved
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof
639cebd 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

stack-info: PR: aws#565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof
17876fa 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

stack-info: PR: aws#565, branch: aws-nslick/stack/12
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
52b6cd4 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick
fix(tuner): avoid gotos (#569)
4cba8b3 
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick merged commit 61a29ab into aws-nslick/stack/10 Sep 27, 2024
24 of 29 checks passed
@aws-nslick aws-nslick mentioned this pull request Sep 27, 2024
Merged
@aws-nslick aws-nslick deleted the aws-nslick/stack/12 branch September 27, 2024 00:55
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
8ca1e53 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
1f0798f 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
24c9d4b 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
a29b7c7 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
b4702c5 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
8239b47 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (aws#565)
5e8e74b 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit that referenced this pull request Oct 1, 2024
@aws-nslick
fix(tree): use __typeof__ instead of typeof (#565)
826419d 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
@aws-nslick @aws-ofiwg-bot
fix(tree): use __typeof__ instead of typeof (aws#565)
0e7b212 
typeof stopped working in newer GCC when in cxx mode. __typeof__ works
in all cases and is the preferred solution for doing this portably.

Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbarrett bwbarrett bwbarrett approved these changes

@rauteric rauteric rauteric left review comments

@rajachan rajachan Awaiting requested review from rajachan

Assignees
No one assigned
Labels
previously-passed-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-nslick @rauteric @bwbarrett