Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tuner): avoid gotos #569

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(tuner): avoid gotos #569

merged 1 commit into from
Sep 27, 2024

Conversation

aws-nslick
Copy link
Contributor

@aws-nslick aws-nslick commented Sep 4, 2024 •
edited
Loading

Stacked PRs:

fix(tuner): avoid gotos

Signed-off-by: Nicholas Sielicki [email protected]

@aws-nslick aws-nslick requested a review from rajachan as a code owner September 4, 2024 20:25
This was referenced Sep 4, 2024
Merged
Closed
Closed
Merged
Merged
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 4, 2024 20:57
@aws-nslick aws-nslick requested review from rauteric, bwbarrett and a team as code owners September 4, 2024 20:57
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 4, 2024 20:59
This was referenced Sep 4, 2024
Merged
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 5, 2024 01:17
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 5, 2024 01:18
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 5, 2024 01:44
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 5, 2024 01:45
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 5, 2024 01:56
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 5, 2024 01:56
@aws-nslick aws-nslick mentioned this pull request Sep 5, 2024
Closed
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 5, 2024 02:03
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 5, 2024 02:03
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 5, 2024 02:07
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 5, 2024 02:08
@aws-nslick
fix(tuner): avoid gotos
23adfcf 
stack-info: PR: #569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/12 to master September 17, 2024 20:24
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/12 September 17, 2024 20:25
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
fix(tuner): avoid gotos
4119ae4 
stack-info: PR: aws#569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
fix(tuner): avoid gotos
b816cb6 
stack-info: PR: aws#569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
fix(tuner): avoid gotos
28b7934 
stack-info: PR: aws#569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
fix(tuner): avoid gotos
439c355 
stack-info: PR: aws#569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(tuner): avoid gotos
8e38426 
stack-info: PR: aws#569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(tuner): avoid gotos
a03b747 
stack-info: PR: aws#569, branch: aws-nslick/stack/16
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
ee7a679 
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick merged commit 4cba8b3 into aws-nslick/stack/12 Sep 27, 2024
33 checks passed
@aws-nslick aws-nslick mentioned this pull request Sep 27, 2024
Merged
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
730914a 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
ce76285 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
fdadb66 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
e067641 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
b289a66 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
b9f5bdc 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
5e9a8b9 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
df8f184 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
08a39de 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
19dfbef 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
fix(tuner): avoid gotos (aws#569)
7502d65 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit that referenced this pull request Oct 1, 2024
@aws-nslick
fix(tuner): avoid gotos (#569)
ddeaa1c 
Signed-off-by: Nicholas Sielicki <[email protected]>
AmedeoSapio pushed a commit to AmedeoSapio/aws-ofi-nccl that referenced this pull request Oct 3, 2024
@aws-nslick @AmedeoSapio
fix(tuner): avoid gotos (aws#569)
40d536a 
Signed-off-by: Nicholas Sielicki <[email protected]>
(cherry picked from commit ddeaa1c)
AmedeoSapio pushed a commit to AmedeoSapio/aws-ofi-nccl that referenced this pull request Oct 3, 2024
@aws-nslick @AmedeoSapio
fix(tuner): avoid gotos (aws#569)
a11becf 
Signed-off-by: Nicholas Sielicki <[email protected]>
(cherry picked from commit ddeaa1c)
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
@aws-nslick @aws-ofiwg-bot
fix(tuner): avoid gotos (aws#569)
353e9e5 
Signed-off-by: Nicholas Sielicki <[email protected]>
AmedeoSapio pushed a commit that referenced this pull request Oct 4, 2024
@aws-nslick @AmedeoSapio
fix(tuner): avoid gotos (#569)
18e5d56 
Signed-off-by: Nicholas Sielicki <[email protected]>
(cherry picked from commit ddeaa1c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbarrett bwbarrett bwbarrett approved these changes

@rajachan rajachan Awaiting requested review from rajachan

@rauteric rauteric Awaiting requested review from rauteric

Assignees
No one assigned
Labels
previously-passed-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aws-nslick @bwbarrett