fix(tuner): fix implicit conversions #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-nslick
force-pushed
the
aws-nslick/stack/20
branch
from
c746d1c to
5eb7499
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/19
branch
from
b4206e4 to
21ab1dd
Compare
This was referenced Sep 4, 2024
Merged
aws-nslick
requested review from
rauteric,
bwbarrett and
a team
as code owners
aws-nslick
force-pushed
the
aws-nslick/stack/20
branch
from
5eb7499 to
870eb84
Compare
This was referenced Sep 4, 2024
aws-nslick
force-pushed
the
aws-nslick/stack/20
branch
from
870eb84 to
beab43e
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/20
branch
from
beab43e to
cdcdb8b
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/20
branch
from
cdcdb8b to
5f2335c
Compare
aws-nslick
force-pushed
the
aws-nslick/stack/20
branch
from
c4eea60 to
d4b3764
Compare
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
cpp requires explicit cast to double here. stack-info: PR: aws#573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 22, 2024
cpp requires explicit cast to double here. stack-info: PR: aws#573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <[email protected]>
bwbarrett
approved these changes
Sep 24, 2024
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 25, 2024
cpp requires explicit cast to double here. stack-info: PR: aws#573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 25, 2024
cpp requires explicit cast to double here. stack-info: PR: aws#573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 26, 2024
cpp requires explicit cast to double here. stack-info: PR: aws#573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 26, 2024
cpp requires explicit cast to double here. stack-info: PR: aws#573, branch: aws-nslick/stack/20 Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 26, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 27, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 28, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 28, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Sep 30, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
to aws-nslick/nccl-net-ofi
that referenced
this pull request
Oct 1, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick
added a commit
that referenced
this pull request
Oct 1, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
AmedeoSapio
pushed a commit
to AmedeoSapio/aws-ofi-nccl
that referenced
this pull request
Oct 3, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]> (cherry picked from commit f89fc73)
AmedeoSapio
pushed a commit
to AmedeoSapio/aws-ofi-nccl
that referenced
this pull request
Oct 3, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]> (cherry picked from commit f89fc73)
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]>
AmedeoSapio
pushed a commit
that referenced
this pull request
Oct 4, 2024
cpp requires explicit cast to double here. Signed-off-by: Nicholas Sielicki <[email protected]> (cherry picked from commit f89fc73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(tuner): fix implicit conversions
cpp requires explicit cast to double here.
Signed-off-by: Nicholas Sielicki [email protected]