Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(param): add uint parameter macro #570

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat(param): add uint parameter macro #570

merged 1 commit into from
Sep 27, 2024

Conversation

aws-nslick
Copy link
Contributor

@aws-nslick aws-nslick commented Sep 4, 2024 •
edited
Loading

Stacked PRs:

feat(param): add uint parameter macro

Signed-off-by: Nicholas Sielicki [email protected]

@aws-nslick aws-nslick requested a review from a team as a code owner September 4, 2024 20:25
This was referenced Sep 4, 2024
Merged
Closed
Closed
Merged
Merged
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/16 to master September 4, 2024 20:57
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 4, 2024 20:59
This was referenced Sep 4, 2024
Merged
Merged
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 5, 2024 01:17
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 5, 2024 01:18
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 5, 2024 01:44
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 5, 2024 01:45
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 5, 2024 01:56
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 5, 2024 01:56
@aws-nslick aws-nslick mentioned this pull request Sep 5, 2024
Closed
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 5, 2024 02:03
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 5, 2024 02:03
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 5, 2024 02:08
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 14, 2024 22:37
@aws-nslick
feat(param): add uint parameter macro
a1c3e27 
stack-info: PR: #570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/20 to master September 17, 2024 20:24
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/20 September 17, 2024 20:26
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
feat(param): add uint parameter macro
af9194a 
stack-info: PR: aws#570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
feat(param): add uint parameter macro
0db9439 
stack-info: PR: aws#570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
feat(param): add uint parameter macro
73a5ac1 
stack-info: PR: aws#570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
@a-szegel
Copy link
Contributor

a-szegel commented Sep 25, 2024 •
edited
Loading

bot:aws:retest ... using this PR to confirm CI is working well

aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
feat(param): add uint parameter macro
8710f5b 
stack-info: PR: aws#570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
feat(param): introduce uint parameter macro
855bcc2 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

stack-info: PR: aws#570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
feat(param): introduce uint parameter macro
9746e3b 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

stack-info: PR: aws#570, branch: aws-nslick/stack/17
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
879746e 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick merged commit b9496e4 into aws-nslick/stack/20 Sep 27, 2024
33 checks passed
@aws-nslick aws-nslick mentioned this pull request Sep 27, 2024
Merged
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
32deaf1 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick deleted the aws-nslick/stack/17 branch September 27, 2024 00:55
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
f10de37 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
02b78de 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
8cb419b 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
51b002b 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
8617352 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
add0fa0 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
8ac09d4 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
90f8590 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
85dfeb1 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(param): introduce uint parameter macro (aws#570)
93726cd 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit that referenced this pull request Oct 1, 2024
@aws-nslick
feat(param): introduce uint parameter macro (#570)
cc7f71d 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
@aws-nslick @aws-ofiwg-bot
feat(param): introduce uint parameter macro (aws#570)
ff453fc 
mr_key_size(), round_robin_threshold(), and eager_max_size() are
strictly positive integers, but due to how we access them through our
environment variable parameter macros, they are accessed as signed ints.
When we eventually want to compare this against `size_t`s and other
unsigned types, this creates sign comparison warnings.

Just duplicate the macro so we can define unsigned environment params,
and then move them to the unsigned macro.

Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauteric rauteric rauteric left review comments

@bwbarrett bwbarrett bwbarrett approved these changes

@rajachan rajachan Awaiting requested review from rajachan

Assignees
No one assigned
Labels
previously-passed-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aws-nslick @a-szegel @rauteric @bwbarrett