Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): use correct __cplusplus guards #554

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

rauteric
rauteric previously approved these changes Sep 4, 2024
include/nccl-headers/neuron/error.h Show resolved Hide resolved
@aws-nslick aws-nslick dismissed bwbarrett’s stale review September 4, 2024 18:14

Unrelated to commit contents, erroneously commented on code instead of pull request.

the canonical token is __cplusplus not _cplusplus. When this is
incorrect, linkage fails as cxx will perform name mangling when
including these headers, resulting in a function with that mangle not
existing.

stack-info: PR: #554, branch: aws-nslick/stack/1
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick changed the title tree: fix __cplusplus guards fix(tree): use correct __cplusplus guards Sep 4, 2024
@aws-nslick
Copy link
Contributor Author

aws:bot:retest

1 similar comment
@aws-nslick
Copy link
Contributor Author

aws:bot:retest

@a-szegel
Copy link
Contributor

a-szegel commented Sep 5, 2024

bot:aws:retest

1 similar comment
@a-szegel
Copy link
Contributor

a-szegel commented Sep 5, 2024

bot:aws:retest

@aws-nslick aws-nslick merged commit c0a9ffb into master Sep 6, 2024
63 checks passed
@aws-nslick aws-nslick deleted the aws-nslick/stack/1 branch September 6, 2024 20:46
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
the canonical token is __cplusplus not _cplusplus. When this is
incorrect, linkage fails as cxx will perform name mangling when
including these headers, resulting in a function with that mangle not
existing.

stack-info: PR: aws#554, branch: aws-nslick/stack/1
Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants