Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): add -Wextra to "picky" compiler flags #588

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat(build): add -Wextra to "picky" compiler flags #588

merged 1 commit into from
Sep 27, 2024

Conversation

aws-nslick
Copy link
Contributor

@aws-nslick aws-nslick commented Sep 11, 2024 •
edited
Loading

Stacked PRs:

feat(build): add -Wextra to "picky" compiler flags

Signed-off-by: Nicholas Sielicki [email protected]

This was referenced Sep 11, 2024
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/29 to master September 11, 2024 23:12
@aws-nslick aws-nslick requested review from rajachan, rauteric and a team as code owners September 11, 2024 23:12
@aws-nslick aws-nslick force-pushed the aws-nslick/stack/30 branch 2 times, most recently from 163c6bf to a7cca1a Compare September 11, 2024 23:12
@aws-nslick aws-nslick mentioned this pull request Sep 11, 2024
Merged
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
53ceba2 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: #588, branch: aws-nslick/stack/30
@aws-nslick aws-nslick changed the base branch from aws-nslick/stack/36 to master September 17, 2024 20:25
@aws-nslick aws-nslick changed the base branch from master to aws-nslick/stack/36 September 17, 2024 20:26
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
5b76f23 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: aws#588, branch: aws-nslick/stack/30
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 22, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
cc5effe 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: aws#588, branch: aws-nslick/stack/30
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
9df0e22 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: aws#588, branch: aws-nslick/stack/30
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 25, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
51b8700 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: aws#588, branch: aws-nslick/stack/30
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
9c422d4 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: aws#588, branch: aws-nslick/stack/30
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags
564b1f0 
Signed-off-by: Nicholas Sielicki <[email protected]>

stack-info: PR: aws#588, branch: aws-nslick/stack/30
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 26, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
797220f 
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick merged commit c56ceb5 into aws-nslick/stack/36 Sep 27, 2024
32 of 33 checks passed
@aws-nslick aws-nslick mentioned this pull request Sep 27, 2024
Merged
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
3369a2e 
Signed-off-by: Nicholas Sielicki <[email protected]>
@aws-nslick aws-nslick deleted the aws-nslick/stack/30 branch September 27, 2024 00:56
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
2f6ca0a 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
13c78b9 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 27, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
6ec3ccd 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
b45d7e8 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 28, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
9089e25 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
d009c83 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
cb9dc75 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
ba70d3f 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
36d0638 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Sep 30, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
065cd63 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
933ef19 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit to aws-nslick/nccl-net-ofi that referenced this pull request Oct 1, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (aws#588)
12fcebf 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-nslick added a commit that referenced this pull request Oct 1, 2024
@aws-nslick
feat(build): add -Wextra to "picky" compiler flags (#588)
552ca4d 
Signed-off-by: Nicholas Sielicki <[email protected]>
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
@aws-nslick @aws-ofiwg-bot
feat(build): add -Wextra to "picky" compiler flags (aws#588)
56ecb1b 
Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbarrett bwbarrett bwbarrett approved these changes

@rauteric rauteric rauteric left review comments

@rajachan rajachan Awaiting requested review from rajachan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-nslick @rauteric @bwbarrett