Missing Event for logging when users toggle telemetry on/off #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 5, 2023 09:44
…telemetry on or off
justinmk3
reviewed
Dec 13, 2023
| "name": "toolkitTelemetryStatusType", | ||
| "type": "string", | ||
| "description": "The type to determine the users status of having telemetry event submitted or not.", | ||
| "allowedValues": ["OFF", "ON"] |
There was a problem hiding this comment.
is a new type needed for this or could it use this:
aws-toolkit-common/telemetry/definitions/commonDefinitions.json
Lines 257 to 260 in ffab908
There was a problem hiding this comment.
If we do carry this out, I would like to re-use types. I will delete this type from the PR.
|
The telemetry system implemented into each of the three Toolkits does not support this use case. Those systems are deliberately designed to ensure that metrics are not transmitted when users opt-out of telemetry. I'm closing this PR, since there is no value in defining a metric that can't be used the way you've intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We do not log when users turn off/on telemetry
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.