Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Event for logging when users toggle telemetry on/off #650

Closed
wants to merge 13 commits into from
Closed

Missing Event for logging when users toggle telemetry on/off #650

Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d36a467
Feature - add shared telemetry metrics for AmazonQ Transform
Dec 5, 2023
e6197ca
Chore - remove type codeTransformConfigurationFilePath
Dec 5, 2023
66ae21f
Chore - update metric description definitions text
Dec 5, 2023
088e482
Chore - remove isVisibleToUser field
Dec 5, 2023
a16a54d
Chore - add newline character to file
Dec 5, 2023
c24e11a
Chore - update description for total runtime
Dec 5, 2023
a43ecff
Chore - fix build isssue to replace allowedValues spaces with undersc…
Dec 5, 2023
76c203a
Chore - follow up with jetbrains underscore conversion
Dec 5, 2023
56a25fe
Merge branch 'main' of github.com:damntrecky/aws-toolkit-common
Dec 11, 2023
60775f7
Merge remote-tracking branch 'upstream/main'
Dec 11, 2023
7d84246
Merge remote-tracking branch 'upstream/main'
Dec 13, 2023
ffab908
Feature - add toolkit_telemetryStatus event to log when users toggle …
Dec 13, 2023
4c3363f
Chore - remove unnecessary type and use existing enabled type
Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
{
"types": [
{
"name": "toolkitTelemetryStatusType",
"type": "string",
"description": "The type to determine the users status of having telemetry event submitted or not.",
"allowedValues": ["OFF", "ON"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a new type needed for this or could it use this:

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Lines 257 to 260 in ffab908

"name": "enabled",
"type": "boolean",
"description": "True if turned on, false if turned off"
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do carry this out, I would like to re-use types. I will delete this type from the PR.

},
{
"name": "appRunnerServiceSource",
"type": "string",
Expand Down Expand Up @@ -1062,6 +1068,14 @@
}
],
"metrics": [
{
"name": "toolkit_telemetryStatus",
"description": "A event for when users toggle the telemetry status for reporting metrics.",
"metadata": [
{ "type": "result" },
{ "type": "toolkitTelemetryStatusType" }
]
},
{
"name": "apigateway_copyUrl",
"description": "Copying an API Gateway remote URL",
Expand Down