added ComputeEnv as type with dev, local, test, web, cc, cloud9, wsl,… #665
Conversation
telemetry/service/service-model.json
Outdated
| "cloud9", | ||
| "codeCatalyst", |
There was a problem hiding this comment.
do we need a type for a Cloud9 + CodeCatalyst?
There was a problem hiding this comment.
since this is (currently) an enum instead of a list, yes. there should be a cloud9Codecatalyst item
There was a problem hiding this comment.
what are other combinations? if env can be combined & there are multiple combinations, it is good idea to instrument on Tookits' code insead?
There was a problem hiding this comment.
what are other combinations? if env can be combined
That's a judgment call. The idea here (and in the quip doc) is to figure that out. I think we have decided it by now. The combinations are as we've listed them here (after making the changes mentioned in this PR).
telemetry/service/service-model.json
Outdated
| "enum":[ | ||
| "cloud9", | ||
| "codeCatalyst", | ||
| "dev", |
There was a problem hiding this comment.
is this for "gamma" or something like that?
There was a problem hiding this comment.
actually i added two words for dev & local that mean the same. removed it
telemetry/service/service-model.json
Outdated
| "type":"string", | ||
| "enum":[ | ||
| "cloud9", | ||
| "codeCatalyst", |
There was a problem hiding this comment.
i do not remember the exact context why this file is in the public repo, but changes need to be backported to the internal .xml file to take effect service-side
There was a problem hiding this comment.
Co-authored-by: Justin M. Keyes <[email protected]>
…ub.com:aws/aws-toolkit-common into gajjardh/add-comput-env-field-to-metric-events
dhruvigajjar
deleted the
gajjardh/add-comput-env-field-to-metric-events
branch
Problem
Problem : Identify the ENV in metrics. Since different env have different user flows, this field becomes helpful in understanding why some metrics are emitted or better understand user flow w.r.t to ENVS
initially adding "ec2", "codecatalyst", "cloud9", "wsl", "test", "vscode-web", "sagemaker", etc.
we can add more later
field name = computeEnv, analogous to the existing computeRegion field
Solution
For all Toolkits to utilize field, adding ComputeEnv Field in PostMetricsRequest & PostFeedbackRequest
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.