Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ComputeEnv as type with dev, local, test, web, cc, cloud9, wsl,… #665

Merged
merged 4 commits into from
Jan 16, 2024
Merged

added ComputeEnv as type with dev, local, test, web, cc, cloud9, wsl,… #665

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2562d2
added ComputeEnv as type with dev, local, test, web, cc, cloud9, wsl,…
dhruvigajjar Jan 8, 2024
2f5002e
Update telemetry/service/service-model.json
dhruvigajjar Jan 10, 2024
63f38f5
added cloud9-codecatalyst
dhruvigajjar Jan 10, 2024
2ac8db5
Merge branch 'gajjardh/add-comput-env-field-to-metric-events' of gith…
dhruvigajjar Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions telemetry/service/service-model.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not remember the exact context why this file is in the public repo, but changes need to be backported to the internal .xml file to take effect service-side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://code.amazon.com/reviews/CR-111231197/revisions/1#/details

Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,23 @@
"type":"string",
"max":2000
},
"ComputeEnv":{
"type":"string",
"enum":[
"cloud9",
"cloud9-codecatalyst",
"cloud9-ec2",
"codecatalyst",
"ec2",
"local",
"sagemaker",
"ssh",
"test",
"web",
"wsl",
"other"
]
},
"Datapoint":{
"type":"double",
"min":0
Expand Down Expand Up @@ -169,6 +186,7 @@
"AWSProductVersion":{"shape":"AWSProductVersion"},
"OS":{"shape":"Value"},
"OSVersion":{"shape":"Value"},
"CommputeEnv": {"shape":"ComputeEnv"},
"ParentProduct":{"shape":"Value"},
"ParentProductVersion":{"shape":"Value"},
"Metadata":{"shape":"Metadata"},
Expand All @@ -191,6 +209,7 @@
"OS":{"shape":"Value"},
"OSArchitecture":{"shape":"Value"},
"OSVersion":{"shape":"Value"},
"CommputeEnv": {"shape":"ComputeEnv"},
"ParentProduct":{"shape":"Value"},
"ParentProductVersion":{"shape":"Value"},
"MetricData":{"shape":"MetricData"}
Expand Down