Measure whether CodeWhisperer is enabled or not #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvigajjar
approved these changes
Feb 16, 2024
shruti0085
reviewed
Feb 16, 2024
| { | ||
| "name": "codewhisperer_enabled", | ||
| "description": "Whether or not CodeWhisperer is enabled", | ||
| "passive": true, |
There was a problem hiding this comment.
Shouldn't this be false for when state change occurs? Users would have explicitly toggled this then.
There was a problem hiding this comment.
Yeah this doesn't seem passive. Also could use the existing metric aws_modifySetting (which is not passive):
There was a problem hiding this comment.
Because this event can occur at arbitrary times (like startup), it should never be set to active, as this would generate false actives. This metric isn't critical in measuring active use (there are other actions/metrics that do this), so having perfect "active use" fidelity around this metric would not give us any additional insights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to understand how often users turn CodeWhisperer on or off.
Solution
Measure the current state at startup, and when explicitly turned on/off.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.