Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure whether CodeWhisperer is enabled or not #699

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Measure whether CodeWhisperer is enabled or not #699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3449,6 +3449,21 @@
}
]
},
{
"name": "codewhisperer_enabled",
"description": "Whether or not CodeWhisperer is enabled",
"passive": true,
Copy link
Contributor

@shruti0085 shruti0085 Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be false for when state change occurs? Users would have explicitly toggled this then.

Copy link
Contributor

@justinmk3 justinmk3 Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this doesn't seem passive. Also could use the existing metric aws_modifySetting (which is not passive):

aws-toolkit-common/telemetry/definitions/commonDefinitions.json

Line 2755 in d27338f

"name": "aws_modifySetting",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this event can occur at arbitrary times (like startup), it should never be set to active, as this would generate false actives. This metric isn't critical in measuring active use (there are other actions/metrics that do this), so having perfect "active use" fidelity around this metric would not give us any additional insights.

"metadata": [
{
"type": "source",
"required": true
},
{
"type": "enabled",
"required": true
}
]
},
{
"name": "codecatalyst_createDevEnvironment",
"description": "Create an Amazon CodeCatalyst Dev Environment",
Expand Down
Loading