feat(amazonq): Add credential start url for amazonq events #701
Conversation
| @@ -2791,7 +2791,8 @@ | |||
| "description": "Captures end of the conversation with amazonq /dev", | |||
| "metadata": [ | |||
| { "type": "amazonqConversationId" }, | |||
| { "type": "amazonqEndOfTheConversationLatency", "required": false } | |||
| { "type": "amazonqEndOfTheConversationLatency", "required": false }, | |||
| { "type": "credentialStartUrl", "required": false } | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
will all amazon Q metrics will have credentialStartUrl? or is it like after auth, all metrics will have.
In which cases credentialStartUrl will be empty?
There was a problem hiding this comment.
After auth, all metrics will have credentialStartUrl. As long as you are signed in, you will have a valid non empty credentialStartUrl
There was a problem hiding this comment.
so for users who's auth is expired, we wont have startUrl or we will have last valid startUrl?
There was a problem hiding this comment.
- It is the current active start url.
- If auth expired, there won't be any startUrl. User with expired auth won't be able to invoke the Code path in Q that sends out any telemetry. Without a valid auth, they won't be able to interact with this product at all. Without any valid user interaction, there won't be any telemetry data.
There was a problem hiding this comment.
So which metrics do you emit without auth?
Does that mean some metric must have startUrl because they wont be emitted if auth is invalid?
|
merge conflict |
Fixed in latest commit |
Problem
Amazon Q telemetry events should have startUrl in its field. Because there is a need for more granularity in user connections in order to help diagnose problems.
Solution
Add credential start url for amazonq events. Option for backward compatibility.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.