Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): Add credential start url for amazonq events #701

Merged
merged 2 commits into from
Feb 20, 2024
Merged

feat(amazonq): Add credential start url for amazonq events #701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf5340f
add credential start url for amazonq
leigaol Feb 19, 2024
ae0e4b9
Merge branch 'main' into master
leigaol Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 47 additions & 12 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2803,7 +2803,8 @@
"description": "Captures end of the conversation with amazonq /dev",
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "amazonqEndOfTheConversationLatency", "required": false }
{ "type": "amazonqEndOfTheConversationLatency", "required": false },
{ "type": "credentialStartUrl", "required": false }
]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will all amazon Q metrics will have credentialStartUrl? or is it like after auth, all metrics will have.
In which cases credentialStartUrl will be empty?

Copy link
Contributor Author

@leigaol leigaol Feb 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After auth, all metrics will have credentialStartUrl. As long as you are signed in, you will have a valid non empty credentialStartUrl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for users who's auth is expired, we wont have startUrl or we will have last valid startUrl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It is the current active start url.
  2. If auth expired, there won't be any startUrl. User with expired auth won't be able to invoke the Code path in Q that sends out any telemetry. Without a valid auth, they won't be able to interact with this product at all. Without any valid user interaction, there won't be any telemetry data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So which metrics do you emit without auth?
Does that mean some metric must have startUrl because they wont be emitted if auth is invalid?

{
Expand All @@ -2812,27 +2813,36 @@
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "amazonqGenerateApproachIteration" },
{ "type": "amazonqGenerateApproachLatency" }
{ "type": "amazonqGenerateApproachLatency" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_startConversationInvoke",
"description": "Captures startConversation invocation process",
"metadata": [{ "type": "amazonqConversationId", "required": false }]
"metadata": [
{ "type": "amazonqConversationId", "required": false },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_createUpload",
"description": "Captures createUploadUrl invocation process",
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "amazonqRepositorySize", "required": false },
{ "type": "credentialStartUrl", "required": false },
{ "type": "amazonqUploadIntent", "required": false }
]
},
{
"name": "amazonq_isApproachAccepted",
"description": "User has accepted the approach generated",
"metadata": [{ "type": "enabled" }, { "type": "amazonqConversationId" }]
"metadata": [
{ "type": "enabled" },
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_codeGenerationInvoke",
Expand All @@ -2844,48 +2854,73 @@
{ "type": "amazonqCodeGenerationResult" },
{ "type": "amazonqNumberOfFilesGenerated", "required": false },
{ "type": "amazonqRepositorySize" },
{ "type": "amazonqNumberOfReferences", "required": false }
{ "type": "amazonqNumberOfReferences", "required": false },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_isAcceptedCodeChanges",
"description": "User applied code changes generated for the task.",
"metadata": [{ "type": "enabled" }, { "type": "amazonqConversationId" }]
"metadata": [
{ "type": "enabled" },
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_isProvideFeedbackForCodeGen",
"description": "User asked to regenerate code generation with a comment",
"metadata": [{ "type": "enabled" }, { "type": "amazonqConversationId" }]
"metadata": [
{ "type": "enabled" },
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_isReviewedChanges",
"description": "User reviewed changes",
"passive": true,
"metadata": [{ "type": "enabled" }, { "type": "amazonqConversationId" }]
"metadata": [
{ "type": "enabled" },
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_codeGenerationThumbsUp",
"description": "User clicked on the thumbs up button to say that they are unsatisfied",
"unit": "Count",
"metadata": [{ "type": "amazonqConversationId" }]
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_codeGenerationThumbsDown",
"description": "User clicked on the thumbs down button to say that they are unsatisfied",
"unit": "Count",
"metadata": [{ "type": "amazonqConversationId" }]
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_approachThumbsUp",
"description": "User clicked on the thumbs up button, to mention that they are satisfied",
"unit": "Count",
"metadata": [{ "type": "amazonqConversationId" }]
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "amazonq_approachThumbsDown",
"description": "User clicked on the thumbs down button to say that they are unsatisfied",
"unit": "Count",
"metadata": [{ "type": "amazonqConversationId" }]
"metadata": [
{ "type": "amazonqConversationId" },
{ "type": "credentialStartUrl", "required": false }
]
},
{
"name": "codewhisperer_codePercentage",
Expand Down
Loading