Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated jackson property #391

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

manofthepeace
Copy link
Contributor

Description of changes:
PropertyNamingStrategy.CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES is deprecated since Jackson 2.7 (2.12 is used). This was done to help potentially unblock quarkusio/quarkus#37295

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (398ec05) 28.08% compared to head (c9a103b) 24.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #391      +/-   ##
============================================
- Coverage     28.08%   24.27%   -3.81%     
+ Complexity      574      498      -76     
============================================
  Files           138      138              
  Lines          5256     5256              
  Branches        635      635              
============================================
- Hits           1476     1276     -200     
- Misses         3578     3797     +219     
+ Partials        202      183      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atshaw43
Copy link
Contributor

atshaw43 commented Dec 1, 2023

LGTM

For future note, I see we are testing the EntityImpl serialization here.

@atshaw43 atshaw43 merged commit 26f9a2f into aws:master Dec 1, 2023
6 checks passed
@manofthepeace manofthepeace deleted the fixJacksonDeprecation branch December 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants