Remove notebook export options that are not supported by SMD #691
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** PDF, webPDF, qtpng, and qtpdf exports fail in MaxDome and SageMaker Studio JL, requiring extra configuration and package installations to function. Many of these dependencies are very large, so they are not being considered to be included in the SageMaker Distribution at this time. This PR disables these exporters. **Testing Done** Update jupyter_server_config.py in local workspace and restart server; confirmed failing options no longer appear.
Are we sure users won't install and use the features? Given that these require additional packages - Maybe we notify them somehow but removing them altogether means such users would also have to manually update the server config and restart Jupyter which we do not advertise from what I know? Mainly worried because PDF at least seems like a very basic use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PDF, webPDF, qtpng, and qtpdf exports fail in SageMaker Unified Studio and SageMaker Studio JL, requiring extra configuration and package installations to function. Many of these dependencies are very large, so they are not being considered to be included in the SageMaker Distribution at this time. This PR disables these exporters.
Type of Change
Release Information
Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.
If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]
How Has This Been Tested?
Update jupyter_server_config.py in local workspace and restart server; confirmed failing options no longer appear.
Checklist:
Test Screenshots (if applicable):
Related Issues
Internal Asana tracking
Additional Notes
None