Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v4 preview: adding example folders for AutoScaling and Aurora #7106

Merged
merged 21 commits into from
Dec 6, 2024

Conversation

rlhagerm
Copy link
Contributor

@rlhagerm rlhagerm commented Nov 26, 2024

This pull request adds example folders for preview version for AutoScaling and Aurora. Metadata is not included.
The Aurora and Autoscaling examples are updated to .NET 8, with updated null collection handling to match the SDK preview updates.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Tools This issue relates to a custom tooling to streamline development tasks label Nov 26, 2024
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Nov 27, 2024
@rlhagerm rlhagerm changed the title .NET: adding example folders for preview version for AutoScaling and Aurora .NET v4 preview: adding example folders for AutoScaling and Aurora Nov 27, 2024
@rlhagerm rlhagerm marked this pull request as ready for review November 27, 2024 14:51
@rlhagerm rlhagerm force-pushed the dotnet-version-updates-pt1 branch from d8a5990 to 8a00d3b Compare November 27, 2024 14:51
@rlhagerm rlhagerm self-assigned this Nov 27, 2024
@rlhagerm rlhagerm added the .NET Pull requests that update .net code label Nov 27, 2024
@rlhagerm rlhagerm requested review from a team and cpyle0819 and removed request for a team and cpyle0819 November 27, 2024 14:53
@rlhagerm rlhagerm requested review from meyertst-aws, a team and DavidSouther and removed request for meyertst-aws and a team November 27, 2024 14:53
…doc-sdk-examples into dotnet-version-updates-pt1
Copy link
Contributor

@DavidSouther DavidSouther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like 3 PRs to me. Looks good, some nits that might just be me unfamiliar with .net idioms.

.github/workflows/lint-check-dotnet.yml Outdated Show resolved Hide resolved
dotnetv4/Aurora/Actions/AuroraWrapper.cs Show resolved Hide resolved
dotnetv4/Aurora/Actions/AuroraWrapper.cs Show resolved Hide resolved
dotnetv4/Aurora/Scenarios/AuroraScenario.cs Show resolved Hide resolved
dotnetv4/Aurora/Scenarios/AuroraScenario.cs Show resolved Hide resolved
dotnetv4/Aurora/Scenarios/AuroraScenario.cs Show resolved Hide resolved
dotnetv4/AutoScaling/Actions/AutoScalingActions.csproj Outdated Show resolved Hide resolved
@rlhagerm rlhagerm requested a review from DavidSouther December 2, 2024 15:39
@rlhagerm rlhagerm added the On Call Review needed This work needs an on-call review label Dec 2, 2024
@scmacdon scmacdon added On Call Review complete On call review complete Bug An update to fix incorrect code or typos. and removed On Call Review needed This work needs an on-call review labels Dec 4, 2024
@rlhagerm rlhagerm added Internal To help track internal tickets in a single location. New example request New example requests. and removed Bug An update to fix incorrect code or typos. labels Dec 6, 2024
@rlhagerm rlhagerm added Task A general update to the code base for language clarification, missing actions, tests, etc. and removed New example request New example requests. labels Dec 6, 2024
@scmacdon scmacdon merged commit ab090ed into awsdocs:main Dec 6, 2024
18 of 19 checks passed
shepazon pushed a commit to shepazon/aws-doc-sdk-examples that referenced this pull request Dec 6, 2024
@rlhagerm rlhagerm deleted the dotnet-version-updates-pt1 branch December 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub settings This affects GitHub settings Internal To help track internal tickets in a single location. .NET Pull requests that update .net code On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants