-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET v4 preview: adding example folders for AutoScaling and Aurora #7106
Open
rlhagerm
wants to merge
19
commits into
awsdocs:main
Choose a base branch
from
rlhagerm:dotnet-version-updates-pt1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Tools
This issue relates to a custom tooling to streamline development tasks
label
Nov 26, 2024
rlhagerm
changed the title
.NET: adding example folders for preview version for AutoScaling and Aurora
.NET v4 preview: adding example folders for AutoScaling and Aurora
Nov 27, 2024
rlhagerm
force-pushed
the
dotnet-version-updates-pt1
branch
from
November 27, 2024 14:51
d8a5990
to
8a00d3b
Compare
rlhagerm
requested review from
a team and
cpyle0819
and removed request for
a team and
cpyle0819
November 27, 2024 14:53
rlhagerm
requested review from
meyertst-aws,
a team and
DavidSouther
and removed request for
meyertst-aws and
a team
November 27, 2024 14:53
…doc-sdk-examples into dotnet-version-updates-pt1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like 3 PRs to me. Looks good, some nits that might just be me unfamiliar with .net idioms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GitHub settings
This affects GitHub settings
.NET
Pull requests that update .net code
Tools
This issue relates to a custom tooling to streamline development tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds example folders for preview version for AutoScaling and Aurora. Metadata is not included.
The Aurora and Autoscaling examples are updated to .NET 8, with updated null collection handling to match the SDK preview updates.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.