Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v4 preview: adding example folders for AutoScaling and Aurora #7106

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 18 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions .github/workflows/lint-check-dotnet.yml
rlhagerm marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,35 @@ jobs:
sparse-checkout: |
.github
dotnetv3
- name: Get changed files
id: changed-files
dotnetv4
- name: Get changed files v3
id: changed-files-v3
uses: tj-actions/changed-files@e9772d140489982e0e3704fea5ee93d536f1e275
with:
files: "dotnetv3/**/*.{cs,sln,csproj,json}"
- name: Build check
if: steps.changed-files.outputs.any_changed == 'true'
- name: Build check v3
if: steps.changed-files-v3.outputs.any_changed == 'true'
run: |
cd dotnetv3
dotnet build -v=q --property WarningLevel=0 /clp:ErrorsOnly
- name: Lint and format check
if: steps.changed-files.outputs.any_changed == 'true' && (success() || failure())
- name: Lint and format check v3
if: steps.changed-files-v3.outputs.any_changed == 'true' && (success() || failure())
run: |
cd dotnetv3
dotnet format --verify-no-changes
- name: Get changed files v4
id: changed-files-v4
uses: tj-actions/changed-files@e9772d140489982e0e3704fea5ee93d536f1e275
with:
files: "dotnetv4/**/*.{cs,sln,csproj,json}"
- name: Build check v4
if: steps.changed-files-v4.outputs.any_changed == 'true'
run: |
cd dotnetv4
dotnet build -v=q --property WarningLevel=0 /clp:ErrorsOnly
- name: Lint and format check v4
if: steps.changed-files-v4.outputs.any_changed == 'true' && (success() || failure())
run: |
cd dotnetv4
dotnet format --verify-no-changes

9 changes: 9 additions & 0 deletions .tools/readmes/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,15 @@
"transcribe": "dotnetv3/Transcribe",
"translate": "dotnetv3/Translate",
},
},
4: {
"base_folder": "dotnetv4",
"service_folder": 'dotnetv4/{{service["name"] | capitalize}}',
"sdk_api_ref": 'https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/{{service["name"] | capitalize}}/N{{service["name"] | capitalize}}.html',
"service_folder_overrides": {
"aurora": "dotnetv4/Aurora",
"auto-scaling": "dotnetv4/AutoScaling",
},
}
},
"PHP": {
Expand Down
167 changes: 167 additions & 0 deletions dotnetv4/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,167 @@
# editorconfig.org

# top-most EditorConfig file
root = true

# C# files
[*.cs]
# Organize usings
dotnet_sort_system_directives_first = true
# this. preferences
dotnet_style_qualification_for_field = false:silent
dotnet_style_qualification_for_property = false:silent
dotnet_style_qualification_for_method = false:silent
dotnet_style_qualification_for_event = false:silent
# Language keywords vs BCL types preferences
dotnet_style_predefined_type_for_locals_parameters_members = true:silent
dotnet_style_predefined_type_for_member_access = true:silent
# Parentheses preferences
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
# Modifier preferences
dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
dotnet_style_readonly_field = true:suggestion
# Expression-level preferences
dotnet_style_object_initializer = true:suggestion
dotnet_style_collection_initializer = true:suggestion
dotnet_style_explicit_tuple_names = true:suggestion
dotnet_style_null_propagation = true:suggestion
dotnet_style_coalesce_expression = true:suggestion
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent
dotnet_style_prefer_inferred_tuple_names = true:suggestion
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
dotnet_style_prefer_auto_properties = true:silent
dotnet_style_prefer_conditional_expression_over_assignment = true:silent
dotnet_style_prefer_conditional_expression_over_return = true:silent

###############################
# Naming Conventions #
###############################
# Style Definitions
dotnet_naming_style.pascal_case_style.capitalization = pascal_case
# Use PascalCase for constant fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
dotnet_naming_symbols.constant_fields.applicable_kinds = field
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
dotnet_naming_symbols.constant_fields.required_modifiers = const

###############################
# C# Coding Conventions #
###############################
# var preferences
csharp_style_var_for_built_in_types = true:silent
csharp_style_var_when_type_is_apparent = true:silent
csharp_style_var_elsewhere = true:silent
# Expression-bodied members
csharp_style_expression_bodied_methods = false:silent
csharp_style_expression_bodied_constructors = false:silent
csharp_style_expression_bodied_operators = false:silent
csharp_style_expression_bodied_properties = true:silent
csharp_style_expression_bodied_indexers = true:silent
csharp_style_expression_bodied_accessors = true:silent
# Pattern matching preferences
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
# Null-checking preferences
csharp_style_throw_expression = true:suggestion
csharp_style_conditional_delegate_call = true:suggestion
# Modifier preferences
csharp_preferred_modifier_order = public,private,protected,internal,file,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,required,volatile,async:suggestion
# Expression-level preferences
csharp_prefer_braces = true:silent
csharp_style_deconstructed_variable_declaration = true:suggestion
csharp_prefer_simple_default_expression = true:suggestion
csharp_style_prefer_local_over_anonymous_function = true:suggestion
csharp_style_inlined_variable_declaration = true:suggestion

###############################
# C# Formatting Rules #
###############################
insert_final_newline = false
indent_style = space
indent_size = 4
trim_trailing_whitespace = true
# New line preferences
csharp_new_line_before_open_brace = all
csharp_new_line_before_else = true
csharp_new_line_before_catch = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_members_in_anonymous_types = true
csharp_new_line_between_query_expression_clauses = true
# Indentation preferences
csharp_indent_block_contents = true
csharp_indent_braces = false
csharp_indent_case_contents = true
csharp_indent_case_contents_when_block = true
csharp_indent_switch_labels = true
csharp_indent_labels = one_less_than_current
# Space preferences
csharp_space_after_cast = false
csharp_space_after_colon_in_inheritance_clause = true
csharp_space_after_comma = true
csharp_space_after_dot = false
csharp_space_after_keywords_in_control_flow_statements = true
csharp_space_after_semicolon_in_for_statement = true
csharp_space_around_binary_operators = before_and_after
csharp_space_around_declaration_statements = do_not_ignore
csharp_space_before_colon_in_inheritance_clause = true
csharp_space_before_comma = false
csharp_space_before_dot = false
csharp_space_before_open_square_brackets = false
csharp_space_before_semicolon_in_for_statement = false
csharp_space_between_empty_square_brackets = false
csharp_space_between_method_call_empty_parameter_list_parentheses = false
csharp_space_between_method_call_name_and_opening_parenthesis = false
csharp_space_between_method_call_parameter_list_parentheses = false
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
csharp_space_between_method_declaration_name_and_open_parenthesis = false
csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_parentheses = false
csharp_space_between_square_brackets = false

###############################
# Custom Rules #
###############################
# File header.
file_header_template = Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. \nSPDX-License-Identifier: Apache-2.0
# SA0001: XML comment disable is allowed.
dotnet_diagnostic.SA0001.severity = none
# SA1600: Elements must be documented is disabled.
dotnet_diagnostic.SA1600.severity = none
dotnet_diagnostic.SA1615.severity = none
dotnet_diagnostic.SA0001.severity = suggestion
dotnet_diagnostic.SA1200.severity = suggestion
# IDE0005 remove unused using statements.
dotnet_diagnostic.IDE0005.severity = error
# CS0168 do not allow unused variables.
dotnet_diagnostic.CS0168.severity = error
# CS8601: nullability warnings
dotnet_diagnostic.CS8601.severity = suggestion
dotnet_diagnostic.CS8604.severity = suggestion
# SA1633: allow custom file header.
dotnet_diagnostic.SA1633.severity = none
# SA1101: do not require keyword this.
dotnet_diagnostic.SA1101.severity = none
# SA1309: allow underscores in field names.
dotnet_diagnostic.SA1309.severity = none
# IDE2000: Disallow multiple blank lines.
dotnet_diagnostic.IDE2000.severity = error
# IDE0073: Require a file header.
dotnet_diagnostic.IDE0073.severity = error
# CA1416: Disable system.drawing warnings.
dotnet_diagnostic.CA1416.severity = none
# S2223: Disable static field warnings.
dotnet_diagnostic.S2223.severity = none
# S101: Disable naming warnings.
dotnet_diagnostic.S101.severity = none
# S1118: Disable class naming warnings.
dotnet_diagnostic.S1118.severity = none
# S1104: Disable encapsulation warnings.
dotnet_diagnostic.S1104.severity = none
# S1854: Disable unused variable warnings.
dotnet_diagnostic.S1854.severity = none
Loading
Loading