Fixing a range of compiler warnings for shadow/unused variables #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Most of the OOP/functional clashes were resolved by static where possible, or a free function - SurfacePostOperator involved breaking out private struct definitions into the palace namespace these struct definitions had already bled into the global namespace through the use of accessor functions. - Source of the issue being methods of internal structs believing mat_op and local_to_shared were mirroring the containing classes variables, despite this being impossible.
hughcars
force-pushed
the
hughcars/fix-shadow-and-unused-variable-warnings
branch
from
b8aacb7
to
d70060b
Compare
|
Closed as the code base has moved so much underneath that all these have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
mat_opandlocal_to_shared. Given these subtypes were already being leaked through the accessor methods for their containers, I just moved the types in to the palace namespace.