Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a range of compiler warnings for shadow/unused variables #77

Closed
wants to merge 2 commits into from
Closed

Fixing a range of compiler warnings for shadow/unused variables #77

wants to merge 2 commits into from

Commits on Jul 25, 2023

  1. Fixing a range of compiler warnings for shadow/unused variables 

    - Most of the OOP/functional clashes were resolved by static where possible, or a free function
- SurfacePostOperator involved breaking out private struct definitions into the palace namespace
these struct definitions had already bled into the global namespace through the use of accessor functions.
- Source of the issue being methods of internal structs believing mat_op and local_to_shared were mirroring
the containing classes variables, despite this being impossible.
    @hughcars
    hughcars committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    065dd2d View commit details
    Browse the repository at this point in the history

  2. style

    @hughcars
    hughcars committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d70060b View commit details
    Browse the repository at this point in the history